feat: enable unit tests in CI and renovate auto-merge#210
Merged
Conversation
- Add unitTests/unitTestSetup.cjs to bootstrap the minimum Harper environment (STORAGE_PATH, _DISABLE_NATS) required before ESM modules with module-level side effects can be loaded - Wire setup file into .mocharc.json via "require" so it runs before any test file is evaluated - Add test:unit script (mocha 'unitTests/**/*.test.mjs') to package.json - Add .github/workflows/unit-tests.yaml running on Node 22 + 24 for push/PR, mirroring the build-then-test pattern used by integration tests - Enable automerge on renovate's digest-pin and non-major update rules Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
|
Reviewed; no blockers found. |
- Add Node 20 to unit test CI matrix - Add temp dir cleanup on process exit in unitTestSetup.cjs - Update AGENTS.md to reflect that test:unit now exists in Pro Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kriszyp
requested review from
DavidCockerill,
cb1kenobi and
kylebernhardy
and removed request for
a team and
kylebernhardy
Move --require unitTests/unitTestSetup.cjs from .mocharc.json onto the test:unit npm script so the env overrides (_DISABLE_NATS, STORAGE_PATH) don't bleed into other mocha invocations. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Ethan-Arrowood
approved these changes
May 21, 2026
Keep main's restructured Commands/Repository map/Pro-specific conventions sections; update test commands block and unitTests description to reflect the new test:unit script added by this branch. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cb1kenobi
approved these changes
May 22, 2026
Consistent with harper repo practice. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cb1kenobi
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cross-model review (Gemini)
No blockers. Significant concerns addressed:
— Claude