Update integration tests to use new apis#39
Merged
Conversation
Member
|
I am going to merge this right now because all the tests on main are broken :) |
Member
Author
|
Oh did the submodule get updated on main? I have a commit here that does that so you might need to remove that commit or something. |
heskew
added a commit
that referenced
this pull request
May 18, 2026
…ller hardening Three changes from ai-review-prompts main since this PR was first opened: - #37: harper/common.md gains "Meta-checks" section + reuse / CI hygiene / lockfile drift bullets. - #38: label-gated review for bot-authored PRs (`claude-review` label as opt-in gesture). - #39: workflow-level `permissions: {}` on all reusables. Caller changes in this commit: - Pin bumped to `13cdfab` (post-#37 + post-#38 + post-#39). - `pull_request: types:` adds `labeled` for the bot-PR gesture. - Workflow-level `permissions: {}` on this caller. Per-job grants in the reusable take effect via GH Actions' override semantics — no functional impact, just makes the deny explicit at every level. Repo-side prerequisite (already applied via `gh label create`): - `claude-review` label exists on this repo. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
4 tasks
heskew
added a commit
that referenced
this pull request
May 19, 2026
…bel-gated review Three changes from ai-review-prompts main since this PR was first opened: - #37: harper/common.md gains "Meta-checks" section + reuse / CI hygiene / lockfile drift bullets. - #38: label-gated review for bot-authored PRs (`claude-review` label as opt-in gesture). - #40: revert of #39's workflow-level `permissions: {}` on reusables — #39 broke reusable callers via the calling- workflow-caps-reusable rule. Empirically verified working on harper main (PR #576). Caller changes in this commit: - Pin bumped to `f22bf7d` (post-#37 + post-#38 + post-#40). Catches the pin up from `3278ce4e` (post-#20) which main was rolled back to during the #39 incident. - `pull_request: types:` adds `labeled` so the new bot-PR gesture fires. - **No caller-side `permissions: {}`**. Earlier version included that recommendation from #39; #40 reverted the recommendation. Repo-side prerequisite (already applied via `gh label create`): - `claude-review` label exists on this repo. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires: HarperFast/harper#235