enforce 5 MB default file-size limit on get_component_file#710
Merged
Conversation
Files over the limit return HTTP 413 with a clear message. Operators can raise the cap via operationsApi.componentFile.maxSize in harperdb-config.yaml. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Reviewed; no blockers found. |
Ethan-Arrowood
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #600.
Summary
get_component_filenow refuses files larger than a configurable limit, returning HTTP 413 with a clear error message.5 * 1024 * 1024bytes).operationsApi.componentFile.maxSize(bytes) inharperdb-config.yaml.Changes
components/operations.js— read config value, validate it (guard against non-numeric), checkstats.sizebeforereadFile; compute file path once (DRY)utility/errors/commonErrors.ts— addCONTENT_TOO_LARGE: 413status code; addCOMPONENT_FILE_TOO_LARGEerror messageutility/hdbTerms.ts— addOPERATIONSAPI_COMPONENTFILE_MAXSIZEconfig paramconfig-root.schema.json— documentoperationsApi.componentFile.maxSizeunitTests/server/fastifyRoutes/operations.test.js— add test for the 413 rejection pathNotes for reviewer
projectis a pre-existing gap ingetComponentFileValidator(not introduced here); flagged separately.Generated by Claude Sonnet 4.6.