Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miyaguchi Preneel #42

Merged
merged 3 commits into from Sep 8, 2018

Conversation

@HarryR
Copy link
Owner

commented Sep 7, 2018

Fixes #37

@HarryR HarryR merged commit a686fd3 into master Sep 8, 2018

2 of 6 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
CodeFactor 1 issue fixed. 4 issues found.
Details
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@HarryR HarryR deleted the Miyaguchi-Preneel branch Sep 8, 2018

@daira
Copy link

left a comment

12 rounds are not even remotely enough. The MiMC paper says you need ceiling(log3(p)) rounds for e = 5 (that's not a typo; definitely log3), and ceiling(log7(p)) rounds for e = 7.

@HarryR

This comment has been minimized.

Copy link
Owner Author

commented Nov 24, 2018

Yup I 100% agree here, 12 rounds are not enough.

On my todo list is to increase it significantly.

There is a very practical attack against 12 rounds which requires only 128gb of RAM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.