Fix Copyrights

[Shamar]

After the recent reintroduction of the missing 9front's copyright statements to the libsec's code at 81d25a4, it has been jokingly pointed to me that "I'm not worthy", since none of my 6 months of commits have left a sign in Harvey. :-)

After a grep confirming the fact, I've noticed that my port of zlib has been removed and the console has been put back in kernel (removing the user-space filesystem that I wrote in 2015). Also I know that my contributions to the continuous integration and the Coverity integration cannot be evident into the sources.

However looking around I've noticed that at 066eb48 my name and copyright has been removed from two new files that, despite simple in itself, were part of two non trivial contributions at cf801d0 and 5616a46 that moved read(2) and write(2) to user-space while cleaning up the kernel. I realize now that I should have probably amended the copyright of all the files touched by the change, to avoid filling this issue now.

Since I can't find the AUTHORS file referenced by @rminnich in the commit message at 066eb48 it's clear that, actually, an AUTHORS file cannot replace proper copyright statements in the code (as wisely predicted by Ron himself in the mailing list).

I do not remember if I have contributed other non trivial changes to Harvey (that have not been reverted or removed). For example I do not know if the changes at 401284b or at 4392ad3 were trivial or I had to add my copyright to the files modified. I was pretty naive back then, but I guess that if the change is not trivial, the copyright holds even if not noticed in the license's header, so it would probably be better to make it explicit.

Nevertheless, since my name has gone in libc, it's possible that it happened to other contributors too and while I'm not a lawyer, I guess this should be fixed. Unfortunately I have no time to check them all.

As for me I prefer the copyright to be put in the files I contributed to, as suggested by the Ron back in 2015.
Please do not use an AUTHORS file for me, since it has proven to break. I'd like my humble contributions to be noticed in source code just like the others.

Expected behavior

Contributors' names and copyrights are preserved in the code base.

Actual behavior

My name and copyright have been removed from the code, without removing the code or reverting the changes. This might have happened to others.

Steps to reproduce

• clone the repository
• cd to the repository
• grep giacomo@tesio.it -wnr sys/src/libc/
• find | grep AUTHORS

[elbing]

Thanks for the info, an explanation is in PR #699 . We're sorry you could feel bad about this, the reasons weren't from bad feelings, just for preserving the work of all of us, even you, for the future in an homogeneus form and avoiding conflicts, that's all. We copyrighted again write.c and read.c.

Also, your work is in history log of the repo, for all of those who want to learn from it.

Thanks!

[Shamar]

Thanks Álvaro for your prompt response.

I'm a bit surprised by the new policy from Software Freedom Conservancy as it seems in direct contrast with both common practice and with the GPL howto by the Free Software Foundation.
It has the sad effect to disincentive any cleanup on free software, as it's often really time consuming to remove code on a complex application. But at the end of the day, this might explain a lot about the exploding complexity in the free software.

But, don't worry, I know it was just an unfortunate mistake! ;-)

BTW, since it's the only place where authorship is preserved in Harvey I analyzed the git log with the command

git log --author=giacomo@tesio.it --pretty=format:"%h"|xargs git show|less

and found that other copyrights of mine were removed.

My copyright has gone in sys/include/libc.h (copyright amended at 45d24cf and removed at 4c39180), in sys/src/9/port/portclock.c and sys/src/9/port/sysproc.c (copyright amended at 45d24cf and removed at f71bee0) and in sys/src/libc/port/lock.c (copyright amended after lockt(2) introduction at 8896d97 and removed at 066eb48).

Please put back these too.

Also, before closing the issue, you might use the command I provided to check if other contributors' names have gone.

Thanks!

[elbing]

Is there any reamaning code from you in libc.h, portclock.c and sysproc.c? The copyrighted code was removed with the copyright itself. No offense. If any of it is still there we'll be glad to remove it for avoiding issues.
Also the policy is not from sfc, was agreed for the project. For avoiding things like this, precisely.

[elbing]

Other authors can claim individually their issues if they could happen when they want. Every case will be reviewed separately.

[Shamar]

No offense, Álvaro, really. I just open this issue to help fixing a little mistake! ;-)

As far as I can remember I agreed to contribute that way (I even explicitly asked what to do), and my contributions were accepted that way by the project. As far as I know, what was later agreed for the project cannot be applied retroactively.

As for libc,h, all cleanups I did are still there (see for example const qualifiers or the abort macro?).
As for libc/port/lock.c the lockt function is still there.
As for kernel's code I can suppose you still have 64 bit ticks that I introduced.

I'm not against removing my contributions (you can remember that I'm always for simplifying things!), but if you decide to go toward this path I have to ask you to git revert each and every of my commits referencing this issue in the commit message, so that it will be clear from the git log of why that changes has been reverted and why they cannot be added back.

This way my copyrights will be effectively gone, and we will be sure that, 6 month from now, my changes wont be applied again with an "Harvey OS" copyright notice.

[elbing]

Well, seems the only way in what harvey could stop worrying you. So we'll do so. Thanks for the info!

[elbing]

Well, after a reviewing, you claim for copyright in libc.h, sysproc.c, portclock.c and removing lockt/or keeping adding copyright. For being clear and don't back over this in future.
Any other claim?

[Shamar]

Álvaro, I'm sad, really sad. You don't need to worry about me more than any other contributor.

But given your attitude here I see only two possible solution:

1. Add back the copyright notices where they were removed (libc.h, sysproc.c, portclock.c and lockt).
2. git revert each of the 175 commits I contributed to Harvey referencing this issue and documenting somewhere that those changes cannot being reintroduced.

Initially I thought it was a simple mistake easy to fix with the first approach.
But given what I've read here, I strongly prefer the second option: with the first I will keep holding the copyright on my contributions to Harvey, and I really do not want to.
Not because I regret the work we did together. It has been a great time.
And even this unexpected outcome teach me a new lesson.

But I cannot trust you anymore.
You might accidentally remove the copyrights again and I would never notice it. I do not monitor Harvey's sources. This issue has been pointed to me by a friend I suggested to try Harvey as it's more stable than my own Plan 9 fork. Months after the facts.

And since, just like you, I don't want to back over this in future, I think reverting my commits is the only safe solution. That way, I will have no copyrights to claim on the Harvey's code and the git log will inform new contributors about this sad mess.

So please, just do as you said.

[0intro]

I think a reasonable solution to this issue for all of us would be to write a CONTRIBUTORS file listing all the people (with associated e-mail addresses) who contributed to Harvey. This is what most open sources projects do (see Go or Linux for example). What do you think @Shamar?

[Shamar]

David, the CREDITS file in Linux works because of Linus. It's a matter of trust.
Here a CONTRIBUTORS file has been removed at some point. So it's not reliable, here.

The few copyright notices that I added in 2015, were not reliable either: they have been removed once, they might be removed again.

You can see that we need a more reliable solution to this issue.

The best way is to simply git revert each of my commit in reverse order and document somewhere that those changes cannot be applied again, not just because of this issue, but because Harvey does not need them. As far as I can see, something similar happened before, at 279effb, at 23ecd75 and even with the removal of some system call, like sysr1.
So really, where is the problem? How hard can it be?
If the contributions we are talking about are so trivial that they do not deserve a copyright notice, it should be very easy to git revert them! :-)

A more complex but reliable solution could be to add back the copyright notice that I added in 2015 and to make my copyrights explicit in each file that my non trivial commits modified.
Few lines similar to the ones that were added to libsec to fix the 9front's copyright would do.
The redundancy should ensure that my copyrights wont completely disappear again in the future.

Still I prefer the git revert solution. It's simple and clear cut.
And until someone do not try to add the same changes under a different copyright, we will all be fine.

[dancrossnyc]

Ok.

Giacomo's commits have been removed from Harvey.

Closing this issue.

[Shamar]

@dancrossnyc unfortunately while none of my commit is present in Harvey after your git rebase, some code I contributed is still there.

For example the changes I contributed at 401284b and 4392ad3 are still there in both libc.h and in the various other files modified (eg in libc's runestrlen.c, strncat and so on... in kernel's portdat.h, alarm.c and so on...).

This is strange, actually, because those commits are still present on some files in master but not in others.

For example I'm listed among the authors of runestrlen but not in strncat despite the fact they were both modified by the same commit.
Same thing for the changes at 4392ad3: no commit but the code is still there.

I suppose that you accidentally squashed some of my changes into others during the git rebase.

[dancrossnyc]

Yes, in some cases types were widened or code was added or changed for const-correctness. Those are changes that can only be written one way; there is nothing original or significant in their authorship and they cannot reasonably be credited to a single author. Would you seriously suggest that we cannot add a 'const' qualifier to a pointer argument of a function because you did it at some point? That would be rather absurd, don't you think?

Your commits were removed, as you requested. If the effect of those commits were replicated elsewhere, then given that that is the only way to replicate them, there's nothing anyone can do about that.

You are no longer listed as a contributor to Harvey on the main page; whether the effect of trivial changes persists is independent of whether you ever authored similar code.

As for the two files you reference, it is unclear to me why you are listed as a contributor on the one; perhaps this is a github UI issue. If you look at both the blame listing and file history, you are not mentioned anywhere. As I mentioned, the other changes you refer to are trivial changes that can not reasonably be written any other way and you cannot command others to use narrower types or not add const correctness.