Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good Submission... Interrupted 馃槳 #1

Open
chug2k opened this issue Mar 15, 2019 · 0 comments
Open

Good Submission... Interrupted 馃槳 #1

chug2k opened this issue Mar 15, 2019 · 0 comments

Comments

@chug2k
Copy link

chug2k commented Mar 15, 2019

Thanks for your submission, Hasan. The main purpose of this assignment was to introduce you to a pattern that you'll be repeating over and over throughout your frontend career: fetching a list of results from an API, and displaying/formatting the result. This is the most basic yet common task in frontend programming, if you ask me. 馃

High Level Comments

Overall great submission, we clearly didn't get to finish a few things. This is good - you try new things. Now here's what you should do next time: BRANCHES 馃尨 馃帇 馃巹 馃尦 馃尣 !

So after you get your code working once, that goes into master. Now, want to try some crazy filter stuff? Make a new branch for it. That way, you don't get in a weird situation like this where you have things half done, half not done.

Nitpicks

No major nitpicks. Recording for posterity here, the faster way:

checkbox.addEventListener( 'change', () => {
    if(checkbox.checked == true) {
        onlyBBC = true;
    } else if (checkbox.checked == false) {
        onlyBBC = false;
    }
    render();
});

could be

checkbox.addEventListener('change', () => onlyBBC = checkBox.checked);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant