New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added popular function to API #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Left some comments. Also:
- You need tests (both click and function)
- API documentation needs to be updated for this :-)
Should be all good :) |
Indent problem didn't go thrugh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also asked for click
tests :)
Lol I tried to fix your merge conflicts and it broke everything sorry |
Had some issues with getting this, I wanted it to remove all the hash types from the dict if it wasn't in the popular list but for some reason it would only remove a few, yet, if I did it the opposite way (making a new list and then appending) ones, it worked fine. Drove me nuts for a bit. Couldn't find any other cleaner way :(. - If you knew why it was doing this please tell me! :)