Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dollar sign ($) in filename fails health check #21

Closed
deepfriedmind opened this Issue Feb 17, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@deepfriedmind
Copy link

deepfriedmind commented Feb 17, 2019

17-02-2019-13-06-37---Health---check--ERROR----------/Volumes/disk1/TV/Shows/Newsreaders/Season 02/Newsreaders - S02E02 - Motorboating Dads; the Negative $100,000 Question 720p HDTV DD 5.1 x264 - BAJSKORV.mkv
[13:06:37] hb_init: starting libhb thread
[13:06:37] thread 70000df33000 started ("libhb")
HandBrake 1.2.0 (2018122300) - Darwin x86_64 - https://handbrake.fr
8 CPUs detected
Opening /Volumes/disk1/TV/Shows/Newsreaders/Season 02/Newsreaders - S02E02 - Motorboating Dads; the Negative 00,000 Question 720p HDTV DD 5.1 x264 - BAJSKORV.mkv...
[13:06:37] CPU: Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
[13:06:37]  - Intel microarchitecture Kaby Lake
[13:06:37]  - logical processor count: 8
[13:06:37] hb_scan: path=/Volumes/disk1/TV/Shows/Newsreaders/Season 02/Newsreaders - S02E02 - Motorboating Dads; the Negative 00,000 Question 720p HDTV DD 5.1 x264 - BAJSKORV.mkv, title_index=1
disc.c:323: failed opening UDF image /Volumes/disk1/TV/Shows/Newsreaders/Season 02/Newsreaders - S02E02 - Motorboating Dads; the Negative 00,000 Question 720p HDTV DD 5.1 x264 - BAJSKORV.mkv
disc.c:424: error opening file BDMV/index.bdmv
disc.c:424: error opening file BDMV/BACKUP/index.bdmv
[13:06:37] bd: not a bd - trying as a stream/file instead
libdvdnav: Using dvdnav version 6.0.0
libdvdread: Encrypted DVD support unavailable.
libdvdread: Can't stat /Volumes/disk1/TV/Shows/Newsreaders/Season 02/Newsreaders - S02E02 - Motorboating Dads; the Negative 00,000 Question 720p HDTV DD 5.1 x264 - BAJSKORV.mkv
No such file or directory
libdvdread: Could not open /Volumes/disk1/TV/Shows/Newsreaders/Season 02/Newsreaders - S02E02 - Motorboating Dads; the Negative 00,000 Question 720p HDTV DD 5.1 x264 - BAJSKORV.mkv
libdvdnav: vm: failed to open/read the DVD
[13:06:37] dvd: not a dvd - trying as a stream/file instead
[13:06:37] hb_stream_open: open /Volumes/disk1/TV/Shows/Newsreaders/Season 02/Newsreaders - S02E02 - Motorboating Dads; the Negative 00,000 Question 720p HDTV DD 5.1 x264 - BAJSKORV.mkv failed
[13:06:37] scan: unrecognized file type
[13:06:37] libhb: scan thread found 0 valid title(s)
No title found.
HandBrake has exited.
@HaveAGitGat

This comment has been minimized.

Copy link
Owner

HaveAGitGat commented Feb 17, 2019

Hi it appears this is an error which the HandbrakeCLI has produced. It seems the first issue is at:

disc.c:323: failed opening UDF image /Volumes/disk1/TV/Shows/Newsreaders/Season 02/Newsreaders - S02E02 - Motorboating Dads; the Negative 00,000 Question 720p HDTV DD 5.1 x264 - BAJSKORV.mkv

It may be worth checking on the Handbrake forum or subreddit to find out what causes this as I'm not familiar with all Handbrake's error codes.

@deepfriedmind

This comment has been minimized.

Copy link
Author

deepfriedmind commented Feb 18, 2019

It's because of the $1 in the filename, which gets treated like a variable in the shell. How are you escaping filenames passed to HandbrakeCLI?

@HaveAGitGat

This comment has been minimized.

Copy link
Owner

HaveAGitGat commented Feb 18, 2019

Ah very interesting thanks for letting me know. I only did a test on Windows with that file name so didn't run into any problems.

Here is the Linux/macOS command which is executed in shell. I'll have another look to see what can be done to escape special characters.

workerCommand ="HandBrakeCLI -i \"" + currentSourceLine + "\" -o \"" + currentDestinationLine + "\" " + preset;

@HaveAGitGat HaveAGitGat added the bug label Feb 18, 2019

@HaveAGitGat

This comment has been minimized.

Copy link
Owner

HaveAGitGat commented Feb 24, 2019

It's because of the $1 in the filename, which gets treated like a variable in the shell. How are you escaping filenames passed to HandbrakeCLI?

Fixed in v2.0.8 just released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.