Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop-gap to allow saving screenshots on non-flash #256

Closed
wants to merge 2 commits into from

Conversation

@IBwWG
Copy link

commented Jun 20, 2016

Since the current default is broken, not having a save dialog to use on non-flash platforms, this added presetPath feature gives you a way out.

Since the current default is broken, not having a save dialog to use on non-flash platforms, this added presetPath feature gives you a way out.
@Gama11

This comment has been minimized.

Copy link
Member

commented Aug 23, 2016

Travis was failing here on Flash:

haxelib run openfl build coverage flash -Dcoverage1
/home/travis/build/HaxeFlixel/flixel-addons/flixel/addons/plugin/screengrab/FlxScreenGrab.hx:220: characters 6-10 : Unknown identifier : path
/home/travis/build/HaxeFlixel/flixel-addons/flixel/addons/plugin/screengrab/FlxScreenGrab.hx:220: characters 20-24 : Unknown identifier : path
/home/travis/build/HaxeFlixel/flixel-addons/flixel/addons/plugin/screengrab/FlxScreenGrab.hx:221: characters 3-13 : Unknown identifier : writerFunc
/home/travis/build/HaxeFlixel/flixel-addons/flixel/addons/plugin/screengrab/FlxScreenGrab.hx:221: characters 14-18 : Unknown identifier : path

Could you update the PR branch? There've been some changes to the Travis config.

@Gama11 Gama11 added the New Feature label Aug 23, 2016
@IBwWG

This comment has been minimized.

Copy link
Author

commented Aug 23, 2016

OK, I'll have to have a look at it later.

@Gama11

This comment has been minimized.

Copy link
Member

commented Aug 30, 2016

Any news?

@IBwWG

This comment has been minimized.

Copy link
Author

commented Aug 30, 2016

Not yet, it may be a few weeks before I have a chance to look at it again. Sorry :(

… the flash case, which is already taken care of in the #if !sys section.
@IBwWG

This comment has been minimized.

Copy link
Author

commented Mar 28, 2017

Travis is passing now, it seems.

@Gama11

This comment has been minimized.

Copy link
Member

commented Apr 21, 2018

Not going to need a workaround for legacy anymore now that we have OpenFL 8 support.

@Gama11 Gama11 closed this Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.