FlxAssetPaths: fix filterExtensions for files with multiple dots #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously getFileReferences filtered extensions using the first string after a dot. This means that myfile.png.old is included even when a filter is set to only import png files. This causes various compiler errors when tortoisesvn is used, due to duplicate file.ext.svn-base files being added. New implementation takes the *last* string after a dot, meaning that myfile.png.old is treated as a .old file and will not be included if "old" is not on the filter list.
Gama11
changed the title
Gama11
added a commit
that referenced
this pull request
Sep 10, 2017
|
Thanks! I added a unit test for this fix here: 29a545d |
jgranick
pushed a commit
to jgranick/flixel
that referenced
this pull request
Jan 31, 2018
…eFlixel#2107) Previously getFileReferences filtered extensions using the first string after a dot. This means that myfile.png.old is included even when a filter is set to only import png files. This causes various compiler errors when tortoisesvn is used, due to duplicate file.ext.svn-base files being added. New implementation takes the *last* string after a dot, meaning that myfile.png.old is treated as a .old file and will not be included if "old" is not on the filter list.
jgranick
pushed a commit
to jgranick/flixel
that referenced
this pull request
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, getFileReferences filtered extensions using the first string after a dot. This means that myfile.png.old is included even when a filter is set to only import png files. This causes various compiler errors when tortoisesvn is used, due to duplicate file.ext.svn-base files being added.
New implementation takes the last string after a dot, meaning that myfile.png.old is treated as a .old file and will not be included if "old" is not on the filter list.