-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fieldHeight
prop for FlxText
to control textfield height
#2789
Conversation
various bugfixes
The deleted assignments actually happen in deep down of `makeGraphic()`. And it is not documented, so it should be fixed too.
- Fix hitbox and field size difference for fixed-size text. - Remove magic const `1.2`: rendered field height does not depend on it, and new field height has no effect since the height is calculated from `textHeight` and not from `height`
Sorry for taking a while to get to this, hopefully soon |
@T1mL3arn you said you had a demo, can you share it? |
https://github.com/T1mL3arn/Flixel-text-height-demo update: Note there are small inconsistencies between flixel and openfl (for neko and hl targets), but I believe they came from openfl itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly needs doc and organizational changes, otherwise seems good
What do you think about adding |
That would be a breaking change, unfortunately, also it's not very commonly used, tbh |
Thanks! |
closes #2783
A fix with backward compatibility. Though I would add
fieldHeight
to the constructor. Also I made sort of a demo with tests, if you want it I will clean up and post here.