Add fieldHeight prop for FlxText to control textfield height
#2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
various bugfixes
The deleted assignments actually happen in deep down of `makeGraphic()`. And it is not documented, so it should be fixed too.
- Fix hitbox and field size difference for fixed-size text. - Remove magic const `1.2`: rendered field height does not depend on it, and new field height has no effect since the height is calculated from `textHeight` and not from `height`
|
Sorry for taking a while to get to this, hopefully soon |
|
@T1mL3arn you said you had a demo, can you share it? |
|
https://github.com/T1mL3arn/Flixel-text-height-demo update: Note there are small inconsistencies between flixel and openfl (for neko and hl targets), but I believe they came from openfl itself. |
Geokureli
requested changes
May 31, 2023
|
What do you think about adding |
That would be a breaking change, unfortunately, also it's not very commonly used, tbh |
Geokureli
approved these changes
Jun 5, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2783
A fix with backward compatibility. Though I would add
fieldHeightto the constructor. Also I made sort of a demo with tests, if you want it I will clean up and post here.