New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP file.seek #4082

Closed
andyli opened this Issue Mar 26, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@andyli
Member

andyli commented Mar 26, 2015

Currently the tests, testSeekEofLast and testSeekEof in TestFileInput, fail on PHP.

@andyli andyli added the platform-php label Mar 26, 2015

Simn added a commit that referenced this issue Mar 26, 2015

@Simn

This comment has been minimized.

Show comment
Hide comment
@Simn

Simn Mar 26, 2015

Member

Should be fixed. I'm not sure what our specification wants with regards to readBytes though, so I left that alone and only changed it for readByte.

Member

Simn commented Mar 26, 2015

Should be fixed. I'm not sure what our specification wants with regards to readBytes though, so I left that alone and only changed it for readByte.

@andyli

This comment has been minimized.

Show comment
Hide comment
@andyli

andyli Mar 26, 2015

Member

Thanks!
Let's close this issue for now. The sys test has not been really completed anyway.

Member

andyli commented Mar 26, 2015

Thanks!
Let's close this issue for now. The sys test has not been really completed anyway.

@andyli andyli closed this Mar 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment