Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10157 Fixes manifest generation on jvm target #10160

Merged

Conversation

davidbruce
Copy link
Contributor

Original issue: #10157

Changes class-path generation for jvm to multiple lines to fix jars with a lot of libraries.

Works on MacOS and Linux, unfortunately I am not able to to test this on Windows at this time, but I don't think there should be an issue.

@davidbruce
Copy link
Contributor Author

I've attempted to fix this, no hard feelings if it isn't what you want, but it's allowing me to get back to work for now.

Also for MacOS I needed to install perl and the String::ShellQuote package to get the opam deps installed properly.

curl -L http://xrl.us/installperlosx | bash
cpan String::ShellQuote

@Simn
Copy link
Member

Simn commented Mar 7, 2021

Thanks for looking into this!

Maybe " lib/%s\n" would be better for the indentation, with "\nClass-Path:" ^ (String.concat "" class_paths). But I don't really mind too much as long as it works.

@davidbruce
Copy link
Contributor Author

I tried " lib/%s\n" initially, but it still didn't work. So, after diffing an old manifest I discovered it needs the space " lib/%s \n". Turns out a manifest is pretty quirky. :P

@Simn
Copy link
Member

Simn commented Mar 7, 2021

Oh well, we can always adjust this later. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants