Skip to content

[cppia] Generate scriptable functions for overriden functions#11773

Merged
Simn merged 1 commit into
HaxeFoundation:developmentfrom
Aidan63:cppia-overloads
Sep 17, 2024
Merged

[cppia] Generate scriptable functions for overriden functions#11773
Simn merged 1 commit into
HaxeFoundation:developmentfrom
Aidan63:cppia-overloads

Conversation

@Aidan63

@Aidan63 Aidan63 commented Sep 15, 2024

Copy link
Copy Markdown
Contributor

Fixes HaxeFoundation/hxcpp#1150

Test has been added in this hxcpp merge HaxeFoundation/hxcpp#1154

That hxcpp merge is failing due to the new test, once this is merged the CI on that hxcpp merge should be re-ran and it will then pass.

@Simn

Simn commented Sep 16, 2024

Copy link
Copy Markdown
Member

Does this interact with overloads somehow given that we're comparing methods by name?

@Aidan63

Aidan63 commented Sep 16, 2024

Copy link
Copy Markdown
Contributor Author

I don't think so. Overloads only really work on extern classes iirc, and that code is only ran on haxe classes and interfaces.

@rainyt

rainyt commented Jan 18, 2025

Copy link
Copy Markdown

This fix doesn't seem to have released a new haxe yet. Can I get a new haxe executable file from the nightly build? Which one is stable? (Mac user)

@rainyt

rainyt commented Jan 18, 2025

Copy link
Copy Markdown

4.3 bug fix did not update this modification. Can it be fixed in 4.3?

@kLabz kLabz added this to the 4.3 Hotfix candidates milestone Jan 18, 2025
@rainyt

rainyt commented Jan 19, 2025

Copy link
Copy Markdown
src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp 
Error: ./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:141:13: error: invalid covariant return type for 'virtual Dynamic haxe::ds::_GenericStack::GenericStackIterator_hscript_Token_obj__scriptable::next()'
   ::Dynamic next(  ) {
             ^
./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:48:19: error:   overriding 'virtual hscript::Token haxe::ds::_GenericStack::GenericStackIterator_hscript_Token_obj::next()'
  ::hscript::Token GenericStackIterator_hscript_Token_obj::next(){
                   ^
./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:152:55: warning: 'fastcall' attribute directive ignored [-Wattributes]
 static void CPPIA_CALL __s_hasNext(::hx::CppiaCtx *ctx) {
                                                       ^
./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:157:52: warning: 'fastcall' attribute directive ignored [-Wattributes]
 static void CPPIA_CALL __s_next(::hx::CppiaCtx *ctx) {
                                                    ^
./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:171:67: warning: 'fastcall' attribute directive ignored [-Wattributes]
 static void CPPIA_CALL __script_construct_func(::hx::CppiaCtx *ctx) {

I have tried this fix, but compilation errors occur.

@rainyt

rainyt commented Jan 20, 2025

Copy link
Copy Markdown

HaxeFoundation/hxcpp#1175

Even with this PR, the test cases cannot pass. This is my issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cppia] Cant seem to get host to call extern super functions

4 participants