Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INT_MAX_VALUE is wrong in HXP... #242

Closed
azrafe7 opened this issue Feb 28, 2014 · 0 comments
Closed

INT_MAX_VALUE is wrong in HXP... #242

azrafe7 opened this issue Feb 28, 2014 · 0 comments
Labels
bug
Milestone
Version 2.5.3

Comments

@azrafe7
Copy link
Member

azrafe7 commented Feb 28, 2014

...and, since it's even, it also negatively affects the behaviour of randomizing functions.

Specifically, with the current implementation of the RNG, it should probably be 2147483647 (as in FlashPunk - also see http://en.wikipedia.org/wiki/Lehmer_random_number_generator).

I'm quite sure the issue is related to old Neko specs (31 bits int), but I think it could be safely fixed now and work cross-targets.

EDIT: Also adding a INT_MIN_VALUE can be helpful.
@MattTuttle MattTuttle added the bug label Mar 1, 2014
@ibilon ibilon added this to the Version 2.5.3 milestone Mar 5, 2014
MattTuttle added a commit that referenced this issue Mar 5, 2014
@MattTuttle
Merge pull request #250 from azrafe7/int-min-max
fc66bd8 
HXP.INT_MIN/MAX_VALUE + small fix for seed clamping (fixes #242) + inite...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Version 2.5.3
Development

No branches or pull requests
3 participants
@MattTuttle @azrafe7 @ibilon