Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: synchronize session on all deletes #214

Merged
merged 2 commits into from Feb 7, 2019

Conversation

@lukehsiao
Copy link
Member

commented Feb 7, 2019

Note that this does have some performance implications [1]:

The 'fetch' strategy results in an additional SELECT statement emitted and will significantly reduce performance.

But some overhead in performance when running clear and clear_all() seems worth it if it eliminates the sqlalchemy error.

See #213.

@lukehsiao lukehsiao added the bug label Feb 7, 2019
@lukehsiao lukehsiao added this to the v0.5.1 milestone Feb 7, 2019
@lukehsiao lukehsiao self-assigned this Feb 7, 2019
lukehsiao added 2 commits Feb 6, 2019
This adds session synchronization to all delete queries in fonduer. Note
that this does have performance implications. Specifically:

> The 'fetch' strategy results in an additional SELECT statement emitted
> and will significantly reduce performance.

from [1].

[1]: https://docs.sqlalchemy.org/en/latest/orm/query.html

Closes #213.
@lukehsiao lukehsiao force-pushed the sync-session branch from 11697c5 to a1d6d8f Feb 7, 2019
@lukehsiao lukehsiao requested a review from SenWu Feb 7, 2019
@SenWu
SenWu approved these changes Feb 7, 2019
@SenWu

This comment has been minimized.

Copy link
Collaborator

commented Feb 7, 2019

Does this fix the #213 ?

@lukehsiao

This comment has been minimized.

Copy link
Member Author

commented Feb 7, 2019

Yes, it does for me.

@SenWu

This comment has been minimized.

Copy link
Collaborator

commented Feb 7, 2019

👍

@lukehsiao lukehsiao merged commit 2f714be into master Feb 7, 2019
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.02%) to 79.115%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@lukehsiao lukehsiao deleted the sync-session branch Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.