Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Figures inside Cells and Paragraphs in Figure #84

Merged
merged 4 commits into from Jul 22, 2018

Conversation

@lukehsiao
Copy link
Member

commented Jul 22, 2018

Many of the hardware domain documents have figures nested inside cells of tables. Our data model needs to support that hierarchy.

This also add support for tail text by an element. For example:

<p><img width="50px" src="http://placebear.com/200/200" alt="bears">TM</p>
@lukehsiao lukehsiao added this to the v0.2.3 milestone Jul 22, 2018
@lukehsiao lukehsiao self-assigned this Jul 22, 2018
@lukehsiao lukehsiao requested a review from SenWu Jul 22, 2018
@lukehsiao lukehsiao changed the title Support Figures inside Cells Support Figures inside Cells and Paragraphs in Figure Jul 22, 2018
@SenWu
SenWu approved these changes Jul 22, 2018
Copy link
Collaborator

left a comment

LGTM.

@SenWu SenWu merged commit b5ba611 into master Jul 22, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 63.87%
Details
@SenWu SenWu deleted the data-model branch Jul 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.