Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get parent/children/sentence generator from Context #87

Merged
merged 1 commit into from Jul 25, 2018

Conversation

@lukehsiao
Copy link
Member

commented Jul 25, 2018

Only a few of the classes inheriting from Context implemented these
functions, and they are not as clear as explicitly navigating the data
model. For example, the Span.get_parent() is less explicit than just
saying Span.sentence. Rather than prsent an interface that is not
explicit and rarely implemented, this commit just removes it.

Only a few of the classes inheriting from Context implemented these
functions, and they are not as clear as explicitly navigating the data
model. For example, the Span.get_parent() is less explicit than just
saying Span.sentence. Rather than prsent an interface that is not
explicit and rarely implemented, this commit just removes it.
@lukehsiao lukehsiao added the clean-up label Jul 25, 2018
@lukehsiao lukehsiao self-assigned this Jul 25, 2018
@lukehsiao lukehsiao requested a review from SenWu Jul 25, 2018
@lukehsiao lukehsiao added this to the v0.3.0 milestone Jul 25, 2018
@SenWu
SenWu approved these changes Jul 25, 2018
Copy link
Collaborator

left a comment

LGTM

@lukehsiao lukehsiao merged commit 661e4ed into master Jul 25, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 63.917%
Details
@lukehsiao lukehsiao deleted the data-model branch Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.