New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2 Major Release - Configurability #17

Merged
merged 18 commits into from Mar 11, 2018

Conversation

Projects
None yet
1 participant
@Headline
Owner

Headline commented Feb 27, 2018

The changes in this branch center around the focus of configuration. Steam-Discord-Bot was originally a project that was specific to my use case, but as the project has grown others have gained interest. This interest was quickly lost due to the sheer amount of hard coded elements that existed throughout this codebase.

So far this branch features

  • Switching XML format to JSON
  • Better organization of pre-built dependencies
  • Replacing legacy mentions of ChancyBot
  • Removed dead (& never working) code
  • Stripped unnecessary logging
  • Added many more configuration options including command disabling, job toggling, forked repository releases configuration, and channel announcement configurations.
  • Dependency removal & in-house Markov text generation

The breaking changes in the update include (but are not necessarily limited to)

  • .xml settings format is no longer supported and configuration must be done in the new format
  • pre-vista support has been dropped, if you're using this platform you must use a build from 1.1. The source for this version is frozen in time in the 1.1-dev branch.

Headline added some commits Feb 26, 2018

Program.cs Outdated
/* Both objects are non null, valid, so lets grab the attribute text */
if (summary != null && command != null)
{
arrayList.Add("!" + command.Text + " - " + summary.Text);

This comment has been minimized.

@Headline

Headline Feb 27, 2018

Owner

Just realized we need to block disabled commands from appearing in the help menu.

Putting this note here for later, so I don’t forget.

Headline added some commits Feb 27, 2018

Fix logic error
SelfUpdateListener should be added when it's enabled and the length ISNT
zero. Not the other way around.
@Headline

This comment has been minimized.

Owner

Headline commented Mar 2, 2018

Since deps were updated, we now need to wait for RogueException/Discord.Net#968 to land which hopefully happens soon. If it sits for weeks we'll use builds off of my fork of Discord.Net even though that's terrible.

@Headline Headline merged commit 263e0c0 into master Mar 11, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Headline Headline deleted the 1.2-dev branch Mar 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment