Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating card bug #361

Open
culinko opened this issue Jan 22, 2016 · 36 comments

Comments

Projects
None yet
@culinko
Copy link
Member

commented Jan 22, 2016

This bug happens after your opponent uses an effect to draw a card, then plays the drawn card very quickly. The played card briefly flickers, then remains hanging mid-air forever. This is not a disconnect, the client is waiting for an animation to finish before continuing to show the result of further actions, but a bug has caused an animation to never finish. If you look at the Power.log when this happens, it shows that the client is correctly receiving further actions from the server, but is incapable of showing them. Your opponent's client is not affected and is able to continue with the game normally. Disconnecting and reconnecting fixes the bug with your client because all animations will be cleared, not because you actually disconnected.

Notably, this bug cannot be used on purpose. If there is a specific timing that reproduces it, you can't just play cards with that specific timing - server latency and CPU speed will cause your opponent to see a different timing and thus not experience the bug. Additionally, the timing and conditions required to perform it are unknown (has never been performed in a controlled environment for example).

Because it is so difficult to reproduce, we need the following information from someone who experiences the floating card bug to help get it fixed:

  1. Videos of the hang starting (not just the card floating indefinitely), like in https://www.youtube.com/watch?v=uDlAIcJnzU0&t=5m13s

  2. output_log.txt from a game where the floating card hang was experienced. Turn on logging here: https://github.com/jleclanche/fireplace/wiki/How-to-enable-logging


Tweeted the devs about this issue (and acknowledged by @ywoo_dev): https://twitter.com/culinko/status/690635196299907072.

Part of the Zone.log comparing normal Abusive Sergeant and bugged Abusive Sergeant (might not be related): https://gist.github.com/culinko/90026b96390a03763ac9. Screenshot from the game below:

dywvnjg

Below is the list of the reports containing screenshots or videos for various draw-related effects:

Life Tap

Shiv

Shield Block

Wrath

Starfire

Battle Rage

Hammer of Wrath

Power Word: Shield

Northshire Cleric

Starving Buzzard

@culinko culinko added this to the 4.1.0.10956 milestone Jan 22, 2016

@culinko culinko changed the title Sometimes, when your opponent draws a card and quickly plays it, your client will hang Floating card bug Jan 22, 2016

@Patashu

This comment has been minimized.

Copy link
Member

commented Jan 22, 2016

Wow, nice job finding out the pattern!

@Patashu

This comment has been minimized.

Copy link
Member

commented Mar 5, 2016

Me and DicePower tried to reproduce this for 20 minutes and failed. The idea was that DicePower would use Life Tap and play the minion targeted card ASAP. When he starts, I'd freeze the client by clicking on the header for varying periods (between half a second and 7 seconds). We got different effects like red targeting arrows pointing from the deck, from the mid-drawn card ,from the hand, the card briefly nudging out of the hand, the card being highlighted as it's drawn, etc. but nothing that looked close to the 'floating card animation hang'.

The timing must be extremely difficult, as playing targeted cards from a draw effect and having small amounts of lag/latency are so common - yet the occurrences of this bug, despite being one of the most reported bugs, isn't THAT high in comparison. So I don't know if trying to reproduce it is ever going to be fruitful without a breakthrough (perhaps by looking at the source code of the client and figuring out what things need to happen).

@Patashu

This comment has been minimized.

Copy link
Member

commented Mar 6, 2016

The topdecked card having a targeted effect might not be a requirement after all. Here's a report from a few days ago where the topdecked card is Defias Ringleader:

http://us.battle.net/hearthstone/en/forum/topic/20742664867

@synap5e

This comment has been minimized.

Copy link

commented Mar 6, 2016

I experimented with having the client play cards drawn from draw effects as soon as they are possible to be played and was not able to cause a hang for the other player, so there's something more going on than the speed at which they play it.

A normal speed video would be helpful as then I would be able to compare the timings.

@Patashu

This comment has been minimized.

Copy link
Member

commented Mar 7, 2016

Loot Hoarder -> Leper Gnome

Interestingly the draw is not from playing a card but from a Deathrattle. Again the topdecked card is non-targeted.

@culinko

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2016

So it looks like just about any card draw effect works to topdeck the 'bugged' card. Life Tap, any draw spell, Beast with Starving Buzzard, Lesser Heal with Northshire Cleric, Loot Hoarder's deathrattle.

Meaning only start turn draw, on-damage triggers like Acolyte and battlecries are not yet observed (I expect everything except start turn draws to work the same way as the rest).

@Patashu

This comment has been minimized.

@Patashu

This comment has been minimized.

Copy link
Member

commented Mar 17, 2016

Due to how frequently this bug got reported up to/including patch 4.1, if it isn't reported once in a week in patch 4.2 we can safely say it's fixed.

@Patashu

This comment has been minimized.

Copy link
Member

commented Mar 17, 2016

@Patashu

This comment has been minimized.

Copy link
Member

commented Mar 19, 2016

Another report in Patch 4.2 with Azure Drake, so this is still around.

http://us.battle.net/hearthstone/en/forum/topic/20742854898

@Patashu Patashu modified the milestones: 4.2.0.12051, 4.1.0.10956 Mar 19, 2016

@Patashu

This comment has been minimized.

Copy link
Member

commented Mar 25, 2016

New video. Well actually old one, but it shows the floating card hang (including start) in 30fps. It's from Kripp!

https://www.youtube.com/watch?v=uDlAIcJnzU0&t=5m13s

@Patashu

This comment has been minimized.

Copy link
Member

commented Apr 17, 2016

Still happens in 4.3 as far as I know, saw some reports on bug report forum today, like

http://us.battle.net/hearthstone/en/forum/topic/20743164632

@Patashu Patashu modified the milestones: 4.3.0.12266, 4.2.0.12051 Apr 17, 2016

@culinko

This comment has been minimized.

Copy link
Member Author

commented Apr 21, 2016

https://www.reddit.com/r/hearthstone/comments/4fqmkl/hearthstone_bug_endless_round/

This might be a proof that it happens on the start of the turn draw as well, but this is a first report of this kind, so I am not 100% sure yet. Also, the player already reconnected before the bug happened (the classes are displayed on the left and because this Tavern Brawl has a mulligan phase, it had to be a reconnect).

@Patashu

This comment has been minimized.

Copy link
Member

commented Apr 25, 2016

@Patashu Patashu modified the milestones: 5.0.0.12574, 4.3.0.12266 Apr 25, 2016

@mgchris1985

This comment has been minimized.

Copy link

commented Apr 25, 2016

feel free to add Archmage Antonidas to the list now too.
https://www.reddit.com/r/hearthstone/comments/4gc183/game_frozen_any_help/

@Patashu

This comment has been minimized.

Copy link
Member

commented Apr 29, 2016

https://www.reddit.com/r/hearthstone/comments/4gw50e/what_just_happened_here_infinite_rope/ Interesting hang. Coldlight Oracle, The Coin, topdecked card.

@culinko

This comment has been minimized.

Copy link
Member Author

commented May 25, 2016

https://www.reddit.com/r/hearthstone/comments/4kw8fo/game_bugged_my_opponent_cant_make_any_moves_and/

Interesting report, if you look at the screenshot, it suggests that the hang happened after the start of turn draw (or a start of turn trigger, because there are 2 cards bugged in the middle.

@Patashu Patashu modified the milestones: 5.0.0.13030, 5.0.0.12574 Jun 13, 2016

@Patashu

This comment has been minimized.

Copy link
Member

commented Jun 13, 2016

I guess everyone forgot to update the milestone :), but I've been seeing this a lot so better do it.

@culinko culinko modified the milestones: 7.1.1.17994, 7.0.0.15590 Mar 14, 2017

@troggnostupidhs

This comment has been minimized.

@troggnostupidhs

This comment has been minimized.

@ande4148

This comment has been minimized.

Copy link

commented Jul 29, 2017

This is still an issue. Just happened to me against rogue auctioneer cycling. Bummer, I was just about to win next turn. Sorry no video.

@culinko culinko modified the milestones: 8.4.0.20022, 8.2.0.19506 Jul 29, 2017

@AnnanFay

This comment has been minimized.

Copy link

commented Sep 14, 2017

Just posting to confirm this is still happening. It was against a warlock in arena.

@culinko culinko modified the milestones: 8.4.0.20022, 9.0.0.20457 Sep 14, 2017

@PattuX

This comment has been minimized.

Copy link

commented Nov 27, 2017

I experienced this 3-4 times over the last few days, but never was a draw involved. However, I know that at least once this happened after Patches was pulled out of the deck. Might this also happen when the opponent attacks with Patches from the deck really fast?

@scsmash3r

This comment has been minimized.

Copy link

commented Dec 24, 2017

It also happens in a dungeon mode. During this bug you can't play any card, cause the game thinks you are pulling one:
hearthstone screenshot 12-24-17 16 33 15

@EfficiencyVI

This comment has been minimized.

Copy link

commented Mar 5, 2018

@FiskFIsk33

This comment has been minimized.

Copy link

commented May 5, 2018

Still happening, got me a loose in arena.

@troggnostupidhs

This comment has been minimized.

@troggnostupidhs

This comment has been minimized.

Copy link
Contributor

commented Dec 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.