fix: bunch of often occurring memory leaks, found by @ArtemRazin

Refs #2574

Author: ansgarbecker

source/connections.pas

@@ -368,6 +368,7 @@ procedure Tconnform.RefreshSessions(ParentNode: PVirtualNode);
       SessNode.Dummy := 0;
     end;
   end;
+  SessionNames.Free;
   if not Assigned(ParentNode) then begin
     RefreshBackgroundColors;
     ListSessions.SortTree(ListSessions.Header.SortColumn, ListSessions.Header.SortDirection);
@@ -418,6 +419,7 @@ procedure Tconnform.FormShow(Sender: TObject);
   LastActiveSession := AppSettings.ReadString(asLastActiveSession);
   if (LastActiveSession = '') and (LastSessions.Count > 0) then
     LastActiveSession := LastSessions[0];
+  LastSessions.Free;
   Node := ListSessions.GetFirst;
   while Assigned(Node) do begin
     PSess := ListSessions.GetNodeData(Node);

source/dbconnection.pas

@@ -11384,9 +11384,11 @@ constructor TSQLFunctionList.Create(AOwner: TDBConnection; SQLFunctionsFileOrder
         FNames.Add(SQLFunc.Name);
       end;
       Ini.Free;
+      Sections.Free;
       Break;
     end;
   end;
+  TryFiles.Free;
 end;
 
 

source/extra_controls.pas

@@ -158,8 +158,6 @@ class procedure TExtForm.RestoreListSetup( List: TLazVirtualStringTree );
   Regname: String;
   OwnerForm: TWinControl;
 begin
-  ValueList := TStringList.Create;
-
   // Column widths
   OwnerForm := GetParentFormOrFrame(List);
   Regname := OwnerForm.Name + '.' + List.Name;
@@ -174,6 +172,7 @@ class procedure TExtForm.RestoreListSetup( List: TLazVirtualStringTree );
       if (List.Header.Columns.Count > i) and (ColWidth > 0) and (ColWidth < 1000) then
         List.Header.Columns[i].Width := ColWidth;
     end;
+    ValueList.Free;
   end;
 
   // Column visibility
@@ -186,6 +185,7 @@ class procedure TExtForm.RestoreListSetup( List: TLazVirtualStringTree );
       else
         List.Header.Columns[i].Options := List.Header.Columns[i].Options - [coVisible];
     end;
+    ValueList.Free;
   end;
 
   // Column position
@@ -199,6 +199,7 @@ class procedure TExtForm.RestoreListSetup( List: TLazVirtualStringTree );
       if List.Header.Columns.Count > i then
         List.Header.Columns[i].Position := colpos;
     end;
+    ValueList.Free;
   end;
 
   // Sort column and direction
@@ -212,9 +213,9 @@ class procedure TExtForm.RestoreListSetup( List: TLazVirtualStringTree );
       else
         List.Header.SortDirection := sdDescending;
     end;
+    ValueList.Free;
   end;
 
-  ValueList.Free;
 end;
 
 

source/table_editor.pas

@@ -446,6 +446,8 @@ procedure TfrmTableEditor.Init(Obj: TDBObject);
     end else
       SynMemoPartitions.Clear;
 
+    rx.Free;
+
     FColumns := DBObject.TableColumns;
     FKeys := DBObject.TableKeys;
     FForeignKeys := DBObject.TableForeignKeys;
@@ -1362,6 +1364,7 @@ procedure TfrmTableEditor.CalcMinColWidth;
     ImageIndexes := GetKeyImageIndexes(FColumns[i]);
     MinWidthThisCol := ImageIndexes.Count * listColumns.Images.Width;
     MinWidthAllCols := Max(MinWidthAllCols, MinWidthThisCol);
+    ImageIndexes.Free;
   end;
   // Add room for text and extra spacing
   Inc(MinWidthAllCols, listColumns.GetMaxColumnWidth(0));