feat: rename snippet per right-click on query helpers tree

Refs #2458

Author: ansgarbecker

source/const.inc

@@ -105,6 +105,7 @@ const
   TextInvalidColumn: String = '';
   FILEFILTER_SQLITEDB = '*.sqlite3;*.sqlite;*.db;*.s3db';
   FILEEXT_SQLITEDB = 'sqlite3';
+  FILEEXT_SNIPPET = '.sql';
   PROPOSAL_ITEM_HEIGHT = 18;
   // Note the following should be in sync to what MySQL returns from SHOW WARNINGS
   SLogPrefixWarning = 'Warning';

source/main.lfm

@@ -21008,6 +21008,12 @@ object MainForm: TMainForm
       ImageIndex = 52
       OnClick = menuLoadSnippetClick
     end
+    object menuRenameSnippet: TMenuItem
+      Caption = 'Rename'
+      Enabled = False
+      ImageIndex = 58
+      OnClick = menuRenameSnippetClick
+    end
     object menuDeleteSnippet: TMenuItem
       Caption = 'Delete ...'
       Enabled = False

source/main.pas

@@ -224,6 +224,7 @@   TMainForm = class(TExtForm)
     FollowForeignKey: TMenuItem;
     menuColorScheme: TMenuItem;
     MenuItem3: TMenuItem;
+    menuRenameSnippet: TMenuItem;
     menuSQLpreferences: TMenuItem;
     menuQFdummy: TMenuItem;
     N1: TMenuItem;
@@ -944,6 +945,7 @@   TMainForm = class(TExtForm)
         TColumnIndex; NewText: String);
     procedure AnyGridPaintText(Sender: TBaseVirtualTree; const TargetCanvas:
         TCanvas; Node: PVirtualNode; Column: TColumnIndex; TextType: TVSTTextType);
+    procedure menuRenameSnippetClick(Sender: TObject);
     procedure menuDeleteSnippetClick(Sender: TObject);
     procedure menuExploreClick(Sender: TObject);
     procedure menuInsertAtCursorClick(Sender: TObject);
@@ -5232,7 +5234,7 @@ procedure TMainform.popupQueryLoadClick(Sender: TObject);
   Filename := (Sender as TMenuItem).Caption;
   Filename := StripHotkey(Filename);
   if Pos('\', Filename) = 0 then // assuming we load a snippet
-    Filename := AppSettings.DirnameSnippets + Filename + '.sql'
+    Filename := AppSettings.DirnameSnippets + Filename + FILEEXT_SNIPPET
   else begin // assuming we load a file from the recent-list
     p := Pos(' ', Filename) + 1;
     filename := Copy(Filename, p, Length(Filename));
@@ -7750,7 +7752,7 @@ procedure TMainForm.SynMemoQueryDragDrop(Sender, Source: TObject; X,
       1:
         case Tree.FocusedNode.Parent.Index of
           TQueryTab.HelperNodeSnippets:
-            Text := ReadTextFile(AppSettings.DirnameSnippets + Tree.Text[Tree.FocusedNode, 0] + '.sql', nil);
+            Text := ReadTextFile(AppSettings.DirnameSnippets + Tree.Text[Tree.FocusedNode, 0] + FILEEXT_SNIPPET, nil);
           TQueryTab.HelperNodeHistory:
             Text := '';
           else begin
@@ -8512,27 +8514,59 @@ procedure TMainForm.insertFunction(Sender: TObject);
 end;
 
 
+procedure TMainForm.menuRenameSnippetClick(Sender: TObject);
+var
+  OldName, NewName: String;
+begin
+  if not Assigned(QueryTabs.ActiveHelpersTree.FocusedNode) then
+    Exit;
+
+  OldName := QueryTabs.ActiveHelpersTree.Text[QueryTabs.ActiveHelpersTree.FocusedNode, 0];
+  NewName := OldName;
+  if InputQuery(_('Rename'), 'Rename snippet "'+OldName+'"', NewName) then
+  begin
+    Screen.Cursor := crHourGlass;
+    if NewName.IsEmpty then begin
+      Screen.Cursor := crDefault;
+      ErrorDialog(f_('Failed renaming %s', ['"' + OldName + '" => "' + NewName + '"']));
+    end
+    else begin
+      OldName := ChangeFileExt(AppSettings.DirnameSnippets + OldName, FILEEXT_SNIPPET);
+      NewName := ChangeFileExt(AppSettings.DirnameSnippets + NewName, FILEEXT_SNIPPET);
+      LogSQL(Format('Rename snippet "%s" to "%s"', [OldName, NewName]), lcDebug);
+      if RenameFile(OldName, NewName) then begin
+        // Refresh list with snippets
+        SetSnippetFilenames;
+      end else begin
+        Screen.Cursor := crDefault;
+        ErrorDialog(f_('Failed renaming %s', ['"' + OldName + '" => "' + NewName + '"']));
+      end;
+    end;
+    Screen.Cursor := crDefault;
+  end;
+end;
+
 {**
   Delete a snippet file
 }
 procedure TMainForm.menuDeleteSnippetClick(Sender: TObject);
 var
-  snippetfile : String;
+  SnippetFile : String;
 begin
   // Don't do anything if no item was selected
   if not Assigned(QueryTabs.ActiveHelpersTree.FocusedNode) then
     Exit;
 
-  snippetfile := AppSettings.DirnameSnippets + QueryTabs.ActiveHelpersTree.Text[QueryTabs.ActiveHelpersTree.FocusedNode, 0] + '.sql';
-  if MessageDialog(_('Delete snippet file?'), snippetfile, mtConfirmation, [mbOk, mbCancel]) = mrOk then
+  SnippetFile := AppSettings.DirnameSnippets + QueryTabs.ActiveHelpersTree.Text[QueryTabs.ActiveHelpersTree.FocusedNode, 0] + FILEEXT_SNIPPET;
+  if MessageDialog(_('Delete snippet file?'), SnippetFile, mtConfirmation, [mbOk, mbCancel]) = mrOk then
   begin
     Screen.Cursor := crHourGlass;
-    if DeleteFileWithUndo(snippetfile) then begin
+    if DeleteFileWithUndo(SnippetFile) then begin
       // Refresh list with snippets
       SetSnippetFilenames;
     end else begin
       Screen.Cursor := crDefault;
-      ErrorDialog(f_('Failed deleting %s', [snippetfile]));
+      ErrorDialog(f_('Failed deleting %s', [SnippetFile]));
     end;
     Screen.Cursor := crDefault;
   end;
@@ -8569,7 +8603,7 @@ procedure TMainForm.menuInsertAtCursorClick(Sender: TObject);
 }
 procedure TMainForm.menuLoadSnippetClick(Sender: TObject);
 begin
-  QueryTabs.ActiveTab.LoadContents(AppSettings.DirnameSnippets + QueryTabs.ActiveHelpersTree.Text[QueryTabs.ActiveHelpersTree.FocusedNode, 0] + '.sql', True, nil);
+  QueryTabs.ActiveTab.LoadContents(AppSettings.DirnameSnippets + QueryTabs.ActiveHelpersTree.Text[QueryTabs.ActiveHelpersTree.FocusedNode, 0] + FILEEXT_SNIPPET, True, nil);
 end;
 
 
@@ -14481,6 +14515,7 @@ procedure TMainForm.treeQueryHelpersContextPopup(Sender: TObject; MousePos: TPoi
   menuQueryHelpersGenerateDelete.Enabled := False;
   menuInsertAtCursor.Enabled := False;
   menuLoadSnippet.Enabled := False;
+  menuRenameSnippet.Enabled := False;
   menuDeleteSnippet.Enabled := False;
   menuExplore.Enabled := False;
   menuHelp.Enabled := False;
@@ -14508,6 +14543,7 @@ procedure TMainForm.treeQueryHelpersContextPopup(Sender: TObject; MousePos: TPoi
         menuInsertAtCursor.Enabled := True;
       end;
       TQueryTab.HelperNodeSnippets: begin
+        menuRenameSnippet.Enabled := True;
         menuDeleteSnippet.Enabled := True;
         menuInsertAtCursor.Enabled := True;
         menuLoadSnippet.Enabled := True;