refactor: replace deprecated SynEdit selection API

Lazarus warns that SelStart/SelEnd are deprecated and very slow. Use native BlockBegin/BlockEnd and CaretXY instead.

Author: jarczakpawel

source/main.pas

@@ -15536,7 +15536,8 @@ function TQueryTab.LoadContents(Filepath: String; ReplaceContent: Boolean; Encod
       Memo.Text := Content
     else
       Memo.SelText := Content;
-    Memo.SelStart := Memo.SelEnd;
+    Memo.CaretXY := Memo.BlockEnd;
+    Memo.ClearSelection;
     Memo.Modified := False;
     MemoFilename := Filepath;
     FileEncoding := MainForm.GetEncodingName(Encoding);

source/texteditor.pas

@@ -108,7 +108,7 @@   TfrmTextEditor = class(TExtForm)
 
 implementation
 
-uses main;
+uses main, Types;
 
 {$R *.lfm}
 
@@ -381,13 +381,13 @@ procedure TfrmTextEditor.comboHighlighterSelect(Sender: TObject);
 var
   Highlighters: TSynHighlighterList;
   i: Integer;
-  SelStart, SelLength: Integer;
+  SelBegin, SelEnd: TPoint;
 begin
   // Code highlighter selected
   if not comboHighlighter.Enabled then
     Exit;
-  SelStart := MemoText.SelStart;
-  SelLength := MemoText.SelEnd - MemoText.SelStart;
+  SelBegin := MemoText.BlockBegin;
+  SelEnd := MemoText.BlockEnd;
   MemoText.Highlighter := nil;
   FHighlighter.Free;
   FHighlighter := nil;
@@ -403,17 +403,17 @@ procedure TfrmTextEditor.comboHighlighterSelect(Sender: TObject);
   menuFormatCodeOnce.Enabled := Assigned(FHighlighter) and (FHighlighterFormatters.IndexOf(FHighlighter.ClassName) > -1);
   if menuAlwaysFormatCode.Checked and menuFormatCodeOnce.Enabled then begin
     menuFormatCodeOnce.OnClick(Sender);
-    SelStart := 0;
-    SelLength := 0;
+    SelBegin := Point(1, 1);
+    SelEnd := SelBegin;
   end;
 
   if Assigned(FHighlighter) then begin
     // Load custom highlighter settings from ini file, if exists:
     MemoText.Highlighter.LoadFromFile(AppSettings.DirnameHighlighters + MemoText.Highlighter.LanguageName + '.ini');
   end;
 
-  MemoText.SelStart := SelStart;
-  MemoText.SelEnd := SelStart + SelLength;
+  MemoText.BlockBegin := SelBegin;
+  MemoText.BlockEnd := SelEnd;
 end;
 
 procedure TfrmTextEditor.btnLoadTextClick(Sender: TObject);
@@ -468,15 +468,15 @@ procedure TfrmTextEditor.menuFormatCodeOnceClick(Sender: TObject);
       JsonParser := TJSONParser.Create(MemoText.Text, []);
       MemoText.Text := JsonParser.Parse.FormatJSON();
       JsonParser.Free;
-      MemoText.SelStart := 0;
-      MemoText.SelEnd := 0;
+      MemoText.CaretXY := Point(1, 1);
+      MemoText.ClearSelection;
     end
     else if FHighlighter is TSynSQLSyn then begin
       // Prefer old internal formatter here, so the user does not run into request limits
       frmReformatter := TfrmReformatter.Create(Self);
       MemoText.Text := frmReformatter.FormatSqlInternal(MemoText.Text);
-      MemoText.SelStart := 0;
-      MemoText.SelEnd := 0;
+      MemoText.CaretXY := Point(1, 1);
+      MemoText.ClearSelection;
       frmReformatter.Free;
     end
     else if FHighlighter is TSynXMLSyn then begin
@@ -492,8 +492,8 @@ procedure TfrmTextEditor.menuFormatCodeOnceClick(Sender: TObject);
         MemoText.BeginUpdate;
         MemoText.Text := OutStream.DataString; // show formatted XML
         MemoText.EndUpdate;
-        MemoText.SelStart := 0;
-        MemoText.SelEnd := 0;
+        MemoText.CaretXY := Point(1, 1);
+        MemoText.ClearSelection;
       finally
         InStream.Free;
         OutStream.Free;