feat: filter edit box for shortcuts in preferences

Refs #2482

Author: ansgarbecker

source/extra_controls.pas

@@ -6,7 +6,7 @@ interface
   System.Classes, System.SysUtils, Vcl.Forms, Winapi.Windows, Winapi.Messages, System.Types, Vcl.StdCtrls, Vcl.Clipbrd,
   SizeGrip, apphelpers, Vcl.Graphics, Vcl.Dialogs, gnugettext, Vcl.ImgList, Vcl.VirtualImageList, Vcl.ComCtrls,
   Winapi.ShLwApi, Vcl.ExtCtrls, VirtualTrees, VirtualTrees.Types, SynRegExpr, Vcl.Controls, Winapi.ShlObj,
-  SynEditMiscClasses, SynUnicode, Vcl.Themes, Vcl.GraphUtil;
+  SynEditMiscClasses, SynUnicode, Vcl.Themes, Vcl.GraphUtil, Math;
 
 type
   // Form with a sizegrip in the lower right corner, without the need for a statusbar
@@ -382,7 +382,7 @@ procedure TExtForm.FilterNodesByEdit(Edit: TButtonedEdit; Tree: TVirtualStringTr
 var
   rx: TRegExpr;
   Node: PVirtualNode;
-  i: Integer;
+  i, ColumnCount: Integer;
   match: Boolean;
   CellText: String;
 begin
@@ -407,8 +407,10 @@ procedure TExtForm.FilterNodesByEdit(Edit: TButtonedEdit; Tree: TVirtualStringTr
     if not Tree.HasChildren[Node] then begin
       // Don't filter anything if the filter text is empty
       match := rx.Expression = '';
+      // Suport trees with 0 defined columns, like the shortcut tree in preferences
+      ColumnCount := Max(Tree.Header.Columns.Count, 1);
       // Search for given text in node's captions
-      if not match then for i := 0 to Tree.Header.Columns.Count - 1 do begin
+      if not match then for i:=0 to ColumnCount - 1 do begin
         CellText := Tree.Text[Node, i];
         match := rx.Exec(CellText);
         if match then

source/preferences.dfm

@@ -1330,10 +1330,10 @@ object frmPreferences: TfrmPreferences
       end
       object TreeShortcutItems: TVirtualStringTree
         Left = 0
-        Top = 0
+        Top = 32
         Width = 300
-        Height = 406
-        Align = alLeft
+        Height = 374
+        Anchors = [akLeft, akTop, akBottom]
         Colors.BorderColor = 15987699
         Colors.DisabledColor = clGray
         Colors.DropMarkColor = 15385233
@@ -1390,6 +1390,19 @@ object frmPreferences: TfrmPreferences
         TabOrder = 2
         OnClick = btnRemoveHotKeyClick
       end
+      object editShortcutsFilter: TButtonedEdit
+        Left = 0
+        Top = 4
+        Width = 300
+        Height = 22
+        Images = MainForm.VirtualImageListMain
+        RightButton.ImageIndex = 193
+        RightButton.Visible = True
+        TabOrder = 3
+        TextHint = 'Filter'
+        OnChange = editShortcutsFilterChange
+        OnRightButtonClick = editShortcutsFilterRightButtonClick
+      end
     end
     object tabFiles: TTabSheet
       Caption = 'Files and tabs'

source/preferences.pas

@@ -33,6 +33,7 @@   TGridColorsPreset = class
   TGridColorsPresetList = TObjectList<TGridColorsPreset>;
 
   TfrmPreferences = class(TExtForm)
+    editShortcutsFilter: TButtonedEdit;
     pagecontrolMain: TPageControl;
     tabMisc: TTabSheet;
     btnCancel: TButton;
@@ -192,6 +193,8 @@   TfrmPreferences = class(TExtForm)
     Label5: TLabel;
     lblReformatter: TLabel;
     comboReformatter: TComboBox;
+    procedure editShortcutsFilterRightButtonClick(Sender: TObject);
+    procedure editShortcutsFilterChange(Sender: TObject);
     procedure FormShow(Sender: TObject);
     procedure Modified(Sender: TObject);
     procedure Apply(Sender: TObject);
@@ -836,6 +839,16 @@ procedure TfrmPreferences.FormShow(Sender: TObject);
   screen.Cursor := crdefault;
 end;
 
+procedure TfrmPreferences.editShortcutsFilterRightButtonClick(Sender: TObject);
+begin
+  editShortcutsFilter.Clear;
+end;
+
+procedure TfrmPreferences.editShortcutsFilterChange(Sender: TObject);
+begin
+  FilterNodesByEdit(editShortcutsFilter, TreeShortcutItems);
+end;
+
 
 
 procedure TfrmPreferences.SQLFontChange(Sender: TObject);