refactor: replace deprecated SynEdit line color API

Lazarus deprecates OnSpecialLineColors. Use OnSpecialLineMarkup while preserving query error and SQL log colors.

Author: jarczakpawel

source/main.lfm

@@ -726,7 +726,7 @@ object MainForm: TMainForm
     MouseLinkColor.Foreground = clBlue
     LineHighlightColor.Background = clNone
     LineHighlightColor.Foreground = clNone
-    OnSpecialLineColors = SynMemoSQLLogSpecialLineColors
+    OnSpecialLineMarkup = SynMemoSQLLogSpecialLineMarkup
     inline SynLeftGutterPartList1: TSynGutterPartList
       object SynGutterLineNumber1: TSynGutterLineNumber
         Width = 13
@@ -3446,7 +3446,7 @@ object MainForm: TMainForm
               OnProcessCommand = SynMemoQueryProcessCommand
               OnReplaceText = SynMemoQueryReplaceText
               OnShowHint = SynMemoQueryShowHint
-              OnSpecialLineColors = SynMemoQuerySpecialLineColors
+              OnSpecialLineMarkup = SynMemoQuerySpecialLineMarkup
               OnStatusChange = SynMemoQueryStatusChange
               inline SynLeftGutterPartList1: TSynGutterPartList
                 object SynGutterMarks1: TSynGutterMarks

source/main.pas

@@ -1234,10 +1234,10 @@   TMainForm = class(TExtForm)
     procedure menuCopyColumnNamesClick(Sender: TObject);
     procedure menuCloseTabOnDblClickClick(Sender: TObject);
     procedure TimerRefreshTimer(Sender: TObject);
-    procedure SynMemoQuerySpecialLineColors(Sender: TObject; Line: Integer;
-      var Special: Boolean; var FG, BG: TColor);
-    procedure SynMemoSQLLogSpecialLineColors(Sender: TObject; Line: Integer;
-      var Special: Boolean; var FG, BG: TColor);
+    procedure SynMemoQuerySpecialLineMarkup(Sender: TObject; Line: Integer;
+      var Special: Boolean; Markup: TSynSelectedColor);
+    procedure SynMemoSQLLogSpecialLineMarkup(Sender: TObject; Line: Integer;
+      var Special: Boolean; Markup: TSynSelectedColor);
     procedure actSequalSuggestExecute(Sender: TObject);
     procedure menuQueryExactRowCountClick(Sender: TObject);
     procedure menuCloseTabOnMiddleClickClick(Sender: TObject);
@@ -7403,8 +7403,8 @@ procedure TMainForm.TimerProposalPopupTimer(Sender: TObject);
 end;}
 
 
-procedure TMainForm.SynMemoQuerySpecialLineColors(Sender: TObject;
-  Line: Integer; var Special: Boolean; var FG, BG: TColor);
+procedure TMainForm.SynMemoQuerySpecialLineMarkup(Sender: TObject;
+  Line: Integer; var Special: Boolean; Markup: TSynSelectedColor);
 var
   Edit: TSynMemo;
   Tab: TQueryTab;
@@ -7416,14 +7416,14 @@ procedure TMainForm.SynMemoQuerySpecialLineColors(Sender: TObject;
     Exit;
   if Line = Tab.ErrorLine then begin
     Special := True;
-    FG := ErrorLineForeground;
-    BG := ErrorLineBackground;
+    Markup.Foreground := ErrorLineForeground;
+    Markup.Background := ErrorLineBackground;
   end;
 end;
 
 
-procedure TMainForm.SynMemoSQLLogSpecialLineColors(Sender: TObject;
-  Line: Integer; var Special: Boolean; var FG, BG: TColor);
+procedure TMainForm.SynMemoSQLLogSpecialLineMarkup(Sender: TObject;
+  Line: Integer; var Special: Boolean; Markup: TSynSelectedColor);
 var
   Edit: TSynMemo;
   LineText, Search: String;
@@ -7436,23 +7436,23 @@ procedure TMainForm.SynMemoSQLLogSpecialLineColors(Sender: TObject;
   //Logsql(LineText+' ::: '+Search);
   if LineText.Contains(Search) then begin
     Special := True;
-    FG := ErrorLineForeground;
-    BG := ErrorLineBackground;
+    Markup.Foreground := ErrorLineForeground;
+    Markup.Background := ErrorLineBackground;
   end
   else if LineText.Contains(_(SLogPrefixWarning)+':') then begin
     Special := True;
-    FG := WarningLineForeground;
-    BG := WarningLineBackground;
+    Markup.Foreground := WarningLineForeground;
+    Markup.Background := WarningLineBackground;
   end
   else if LineText.Contains(_(SLogPrefixNote)+':') then begin
     Special := True;
-    FG := NoteLineForeground;
-    BG := NoteLineBackground;
+    Markup.Foreground := NoteLineForeground;
+    Markup.Background := NoteLineBackground;
   end
   else if LineText.Contains(_(SLogPrefixInfo)+':') then begin
     Special := True;
-    FG := InfoLineForeground;
-    BG := InfoLineBackground;
+    Markup.Foreground := InfoLineForeground;
+    Markup.Background := InfoLineBackground;
   end;
 end;
 
@@ -12658,7 +12658,7 @@ procedure TMainForm.actNewQueryTabExecute(Sender: TObject);
   QueryTab.Memo.Font.Assign(SynMemoQuery.Font);
   QueryTab.Memo.LineHighlightColor.Background := SynMemoQuery.LineHighlightColor.Background;
   QueryTab.Memo.OnStatusChange := SynMemoQuery.OnStatusChange;
-  QueryTab.Memo.OnSpecialLineColors := SynMemoQuery.OnSpecialLineColors;
+  QueryTab.Memo.OnSpecialLineMarkup := SynMemoQuery.OnSpecialLineMarkup;
   QueryTab.Memo.OnDragDrop := SynMemoQuery.OnDragDrop;
   QueryTab.Memo.OnDragOver := SynMemoQuery.OnDragOver;
   QueryTab.Memo.OnDropFiles := SynMemoQuery.OnDropFiles;