New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win 10 is detected as Win 8 in about dialog #119

Closed
zufuliu opened this Issue Feb 6, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@zufuliu

zufuliu commented Feb 6, 2018

Expected behavior

Win 10 is detected as Environment: Windows v10.0. It seems some supportedOS GUIDs is missing from application manifest, some useful links from MSDN:

Current behavior

In About HeidiSQL dialog, Win 10 is detected as Environment: Windows v6.2, which is Win 8.

Context

  • HeidiSQL version: Version 9.5.0.5239 (64 Bit)
  • Database system + version:
  • Operating system: Windows 10.0.16299.214
@ansgarbecker

This comment has been minimized.

Collaborator

ansgarbecker commented Feb 6, 2018

It could be that this is due to the Delphi XE5 compiler and its libraries, which did not know about Win10 when XE5 was released. Well, there is surely some other, more stable way to find the current Windows version.

@ansgarbecker ansgarbecker added the bug label Feb 6, 2018

@zufuliu

This comment has been minimized.

zufuliu commented Feb 7, 2018

In the table footer note in page Operating System Version, MSDN says "Applications not manifested for Windows 8.1 or Windows 10 will return the Windows 8 OS version value (6.2). To manifest your applications for Windows 8.1 or Windows 10, refer to Targeting your application for Windows."

@ansgarbecker

This comment has been minimized.

Collaborator

ansgarbecker commented Feb 7, 2018

Thanks for your investigations. Yes, Heidi's manifest file doesn't even contain a compatibility section, therefore isn't targeted for any of the newer Windows versions.

By the way, is there a better way of linking a source file from an issue comment, instead of using the absolute github link? I am used to do that but that feels wrong: [link text](https://github.com/HeidiSQL/HeidiSQL/blob/master/somefile.txt)

@zufuliu

This comment has been minimized.

zufuliu commented Feb 7, 2018

It seems it's Heidi's manifest file:

[Heidi's manifest file](../blob/master/res/manifest.xml)

as answered in https://stackoverflow.com/questions/16534692/github-issues-reference-a-file-in-the-repo

@ansgarbecker

This comment has been minimized.

Collaborator

ansgarbecker commented Feb 7, 2018

Should be better now. My Win10 shows Environment: Windows v10.0 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment