New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards compatibility for old default snippet directory #159

Closed
ansgarbecker opened this Issue Feb 25, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@ansgarbecker
Collaborator

ansgarbecker commented Feb 25, 2018

Steps to reproduce this issue

  1. use v9.5 release or older
  2. store a snippet file
  3. upgrade to r5244 or newer

Current behavior

Previously stored snippet not displayed. Panic. File deleted or what happened?

Expected behavior

Snippet file should be displayed.

Possible solution

Transfer .sql files from old default snippets directory to new one at application start.
=> Only in non-portable mode
=> and only if CustomSnippetsDirectory <> CSIDL_COMMON_APPDATA\HeidiSQL

Environment

This happens in cases where the user never touched the setting CustomSnippetsDirectory. These were the defaults (e.g. on Win10):

up to HeidiSQL r5243: C:\ProgramData\HeidiSQL\ => CSIDL_COMMON_APPDATA
from r5244 upwards: C:\Users\anse\Documents\HeidiSQL\ => CSIDL_MYDOCUMENTS

Broken by myself in 8b2966c for issue #60.

  • HeidiSQL version: 9.5.0.5244
  • Database system and version: unrelated
  • Operating system: Win10, but unrelated

@ansgarbecker ansgarbecker added the bug label Feb 25, 2018

@ansgarbecker ansgarbecker added this to the v9.6 milestone Feb 25, 2018

CodehunterWorks added a commit that referenced this issue Feb 25, 2018

Merge pull request #160 from HeidiSQL/master
Migrate files from old default snippets directory. Closes #159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment