New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to change the color of highlight fields with same value #224

Closed
albertdick opened this Issue Apr 11, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@albertdick

albertdick commented Apr 11, 2018

I'd like to suggest that the new "highlight fields with same value" feature of #71 might have an option to change the default color. Default color is light grey, as well as NULL field and the selected line. So, "to many shades of grey".

@ansgarbecker

This comment has been minimized.

Collaborator

ansgarbecker commented Apr 11, 2018

Can confirm I also want to have a different color.
I will turn the checkbox into a color selector, while "None" means "disabled".

@ansgarbecker ansgarbecker added this to the v9.6 milestone Apr 11, 2018

@ansgarbecker

This comment has been minimized.

Collaborator

ansgarbecker commented Apr 12, 2018

Just done. Please update to the latest build and report back if that works for you as expected.

@albertdick

This comment has been minimized.

albertdick commented Apr 12, 2018

It's working as I expected.
Thank you!

@yphastos

This comment has been minimized.

yphastos commented Apr 25, 2018

There's a minor bug with this feature.

Steps:

  • Have a result set / data, with few rows/columns,
  • click on any cell with same data as some others in same column. All cells with same data get highlighted with the same color (expected behavior)
  • now click outside the table, (but inside the result section). The previously clicked cell loses focus, but also loses the highlight color, (the rest of 'same value' cells do keep the common color).
  • The expected result would be that the cell that lost focus, should have the same color as the rest of the cells, so visually they are all the same.

Should I open this as a new issue?

@yphastos

This comment has been minimized.

yphastos commented Apr 25, 2018

Update.
When clicking outside the table, the previously selected cell doesn't lose focus, because it keeps the dotted border, and pressing the arrow keys in the keyboard change the selected cells, coloring other cells if applicable.

But it does lose color when clicking outside the table (and inside same section). And now i notice that it also removes the highlight from the selected ROW, but not from the same value cells.

I think it should either remove both highlights (row and same value cells), or keep both.

Note that clicking in other areas of the UI (the query section, the tables list, other tabs, the log area, etc) doesn't remove the highlights (row, cell, and same value cells) but does remove focus (as expected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment