New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't close/clear first query tab #318

Closed
psilent opened this Issue Jul 27, 2018 · 7 comments

Comments

Projects
None yet
4 participants
@psilent

psilent commented Jul 27, 2018

Steps to reproduce this issue

  1. Into the first query tab, open a query file or type some query text.
  2. Double-click tab.

Contents of query tab are not cleared. Associated file name is not cleared. The "close" action on this tab is disabled.

Previously, double-clicking on the first query tab cleared it and disassociated the filename if a file was opened in it (without warning about changed contents).

Enable the close action for the first tab to clear the tab and disassociate any open file if there are no unsaved changes.

  • HeidiSQL version:
    9.5.0.5280 (64 Bit)
  • Database system and version:
    MySql 5.6.17
  • Operating system:
    Windows 10
@rentalhost

This comment has been minimized.

Show comment
Hide comment
@rentalhost

rentalhost Jul 27, 2018

Collaborator

@ansgarbecker while it is a dup from #238, I don't think that Ctrl + W is obvious like just double-click like works in another additional tabs. Do you think that you could reconsider "ask for save" and just clear (instead of close) the last available tab? If you have two+ tabs, the second+ will support double-click to close, the first one will not have.

Collaborator

rentalhost commented Jul 27, 2018

@ansgarbecker while it is a dup from #238, I don't think that Ctrl + W is obvious like just double-click like works in another additional tabs. Do you think that you could reconsider "ask for save" and just clear (instead of close) the last available tab? If you have two+ tabs, the second+ will support double-click to close, the first one will not have.

@ansgarbecker

This comment has been minimized.

Show comment
Hide comment
@ansgarbecker

ansgarbecker Jul 28, 2018

Collaborator

Due to quite a few complaints here I'll go and revert my change for #231, so a double click will also clear the unclosable last tab. Instead, I should probably add a ask-for-save-prompt on that double click.

Collaborator

ansgarbecker commented Jul 28, 2018

Due to quite a few complaints here I'll go and revert my change for #231, so a double click will also clear the unclosable last tab. Instead, I should probably add a ask-for-save-prompt on that double click.

@ansgarbecker

This comment has been minimized.

Show comment
Hide comment
@ansgarbecker

ansgarbecker Aug 4, 2018

Collaborator

Just changed the behaviour like stated above: a double click on the very first tab asks for confirmation to clear the contents and then clears it.
This is a bit inconsistent now, as the friend menu item "Clear editor" does the same without asking the user. I was on the way to add a prompt there too, but then I thought this is not what anybody wants. Please shout if you have suggesstions here.

Collaborator

ansgarbecker commented Aug 4, 2018

Just changed the behaviour like stated above: a double click on the very first tab asks for confirmation to clear the contents and then clears it.
This is a bit inconsistent now, as the friend menu item "Clear editor" does the same without asking the user. I was on the way to add a prompt there too, but then I thought this is not what anybody wants. Please shout if you have suggesstions here.

@psilent

This comment has been minimized.

Show comment
Hide comment
@psilent

psilent Aug 5, 2018

If "Clear editor" is just clearing out the contents of the tab but leaves the file association in place, this is fine not prompting for save as long as the clear is part of the undo history I think. Any action that is going to disassociate an open and modified file should prompt for save since undo will not be available.

psilent commented Aug 5, 2018

If "Clear editor" is just clearing out the contents of the tab but leaves the file association in place, this is fine not prompting for save as long as the clear is part of the undo history I think. Any action that is going to disassociate an open and modified file should prompt for save since undo will not be available.

@Dolass

This comment has been minimized.

Show comment
Hide comment
@Dolass

Dolass Aug 5, 2018

I think you can go return testing Heidisql 9.3.0.4999, because it do best work for this tab function.

Dolass commented Aug 5, 2018

I think you can go return testing Heidisql 9.3.0.4999, because it do best work for this tab function.

@Dolass

This comment has been minimized.

Show comment
Hide comment
@Dolass

Dolass commented Aug 5, 2018

heidisql_exit00
heidisql_dbclick01
heidisql_dbclick02

@ansgarbecker

This comment has been minimized.

Show comment
Hide comment
@ansgarbecker

ansgarbecker Aug 5, 2018

Collaborator

@Dolass: that prompt was part of the discussion in #231 .

Collaborator

ansgarbecker commented Aug 5, 2018

@Dolass: that prompt was part of the discussion in #231 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment