New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect trigger statement's field size #420

Closed
fifonik opened this Issue Dec 3, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@fifonik
Copy link

fifonik commented Dec 3, 2018

Steps to reproduce this issue

  1. Create table and trigger in your database (trigger's body could be empty):
DROP TABLE IF EXISTS `tbl`;
CREATE TABLE `tbl` (
	`id` INT(10) UNSIGNED NOT NULL AUTO_INCREMENT,
	`val` VARCHAR(15) NOT NULL,
	PRIMARY KEY (`id`)
);

DROP TRIGGER IF EXISTS `trg`;
CREATE TRIGGER `trg` BEFORE INSERT ON `tbl` FOR EACH ROW BEGIN
END;
  1. Press F5 to refresh database;

  2. Click at table 'tbl' in the tree, then select 'Table' tab and press F5;

  3. Click at the database in the tree and press F5 again;

  4. Click at trigger 'trg' and you'll see trigger page. However field for the trigger statement will be small:
    heidi_smalltriggerstatementtextarea

  5. Click at table 'tbl' & then on trigger 'trg'. Now you'll see the trigger page with normal field size for trigger statement.

To see the issue again -- repeat steps 3 to 5.

Current behavior

Textarea for trigger statement is too small.

Expected behavior

I'm expecting to see proper size of textarea for trigger statement.

Environment

  • HeidiSQL version: 9.5.0.5362 64bit
  • Operating system: Windows 10 64 bit 1803
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Dec 10, 2018

Using the latest build 5382 on Windows 7 with 125% scaling, I cannot reproduce this issue. Can you?

@fifonik

This comment has been minimized.

Copy link

fifonik commented Dec 10, 2018

I still see the issue in 5382 (Windows 1803, unfortunately I use custom scaling on that PC, will try at home PC with 1809 & default scaling).

I can try to capture screen. However, not sure if this helps.

@ansgarbecker ansgarbecker added this to the v10 milestone Dec 11, 2018

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Dec 23, 2018

I was just able to reproduce this. Another reproduction recipe:

  • click any table so the "table" tab shows the table editor
  • click away from the "table" tab, e.g. to the "database" tab (or "query"...)
  • click any trigger in the tree to show up the trigger editor

Logically, at least one problem is that the "table" tab was used before but is not the active tab while initializing the trigger editor.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Dec 24, 2018

The exact problem was/is, that the trigger editor frame is placed on a non-active tab of the underlying page control. If I activate the tab first, then place the editor there, the problem was fixed. However, that introduced other problems, so the solution is now to align the trigger editor with alClient, activate AlignWithMargins, plus some programmatical code to move the bottom buttons to their correct place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment