New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application sometimes crashes when changing theme #465

Closed
CharlieEtienne opened this Issue Jan 4, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@CharlieEtienne
Copy link
Contributor

CharlieEtienne commented Jan 4, 2019

date/time          : 2019-01-04, 03:30:01, 24ms
computer name      : DESKTOP-UMMGQVM
user name          : Charlie <admin>
registered owner   : Charlie / Microsoft
operating system   : Windows 10 x64 build 17763
system language    : French
system up time     : 12 days 4 hours
program up time    : 24 minutes 3 seconds
processors         : 8x Intel(R) Core(TM) i7-4750HQ CPU @ 2.00GHz
physical memory    : 1176/8081 MB (free/total)
free disk space    : (C:) 24,37 GB
display mode       : 1600x900, 32 bit
process id         : $5d40
allocated memory   : 98,92 MB
largest free block : 131025,96 GB
executable         : heidisql.exe
exec. date/time    : 2019-01-04 03:05
version            : 9.5.0.5437
compiled with      : Delphi 10.3 Rio
madExcept version  : 5.0.0
callstack crc      : $fe52c0b8, $2b6bbc94, $2b6bbc94
exception number   : 1
exception class    : EAccessViolation
exception message  : Access violation at address 00000000007C75E8 in module 'heidisql.exe'. Read of address 0000000000000010.

main thread ($79c0):
007c75e8 heidisql.exe Vcl.Themes            TStyleHook.GetHandle
008552f8 heidisql.exe Vcl.Forms             TFormStyleHook.TMainMenuBarStyleHook.MenuExit
00858ff8 heidisql.exe Vcl.Forms             TFormStyleHook.TMainMenuBarStyleHook.TrackMenuFromItem
00855449 heidisql.exe Vcl.Forms             TFormStyleHook.TMainMenuBarStyleHook.ProcessMenuLoop
00855286 heidisql.exe Vcl.Forms             TFormStyleHook.TMainMenuBarStyleHook.MenuEnter
00858a16 heidisql.exe Vcl.Forms             TFormStyleHook.TMainMenuBarStyleHook.MouseDown
0085ea27 heidisql.exe Vcl.Forms             TFormStyleHook.WMNCLButtonDown
0040e9d2 heidisql.exe System                TObject.Dispatch
007c7e74 heidisql.exe Vcl.Themes            TStyleHook.WndProc
007c81d4 heidisql.exe Vcl.Themes            TMouseTrackControlStyleHook.WndProc
0085e6c2 heidisql.exe Vcl.Forms             TFormStyleHook.WndProc
007c7425 heidisql.exe Vcl.Themes            TStyleHook.HandleMessage
00bafd29 heidisql.exe Vcl.Styles            TStyleEngine.HandleMessage
007c2e9c heidisql.exe Vcl.Themes            TStyleManager.HandleMessage
006a5d64 heidisql.exe Vcl.Controls          TWinControl.DoHandleStyleMessage
006a7e35 heidisql.exe Vcl.Controls          TWinControl.WndProc
0083fefd heidisql.exe Vcl.Forms             TCustomForm.WndProc
006a78da heidisql.exe Vcl.Controls          TWinControl.MainWndProc
0055c293 heidisql.exe System.Classes        StdWndProc
7ffce337 USER32.dll                         DispatchMessageW
0084e07e heidisql.exe Vcl.Forms             TApplication.ProcessMessage
0084e0f3 heidisql.exe Vcl.Forms             TApplication.HandleMessage
0084e541 heidisql.exe Vcl.Forms             TApplication.Run
00dd6c9a heidisql.exe heidisql       85 +26 initialization
7ffce4e9 KERNEL32.DLL                       BaseThreadInitThunk
7ffce50d ntdll.dll                          RtlUserThreadStart

@ansgarbecker ansgarbecker added this to the v10 milestone Jan 4, 2019

@ansgarbecker ansgarbecker added the bug label Jan 4, 2019

ansgarbecker added a commit that referenced this issue Jan 9, 2019

Do not apply selected theme from within the preferences dialog, as th…
…at crashes sporadically. Instead, rely on the info dialog telling the user he should restart the app. Related to #465, and probably solves it.

@ansgarbecker ansgarbecker added the themes label Jan 10, 2019

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Jan 10, 2019

This could already be solved by my recent commit, see above. But that only leaves the current theme active for the session after changing it in preferences, so the theme gets switched on the next restart. I'm not sure if you got that crash within the same session after changing the theme, did you?

@CharlieEtienne

This comment has been minimized.

Copy link
Contributor

CharlieEtienne commented Jan 11, 2019

I could reproduce the issue: (still on 9.5.0.5442)

Steps to reproduce

  1. (Material Theme is selected)
  2. Open settings
  3. Choose Carbon Theme
  4. Apply
  5. Choose Windows 10 theme
  6. Apply
  7. Choose Windows 10 dark theme
  8. Apply
  9. Choose Material Theme back
  10. Apply
  11. Click OK to close
  12. Error "Access violation at address 00000000007C75E8 in module 'heidisql.exe'. Read of address 0000000000000010"

But if I click Continue application, it works.

BUT THEN I RESTARTED AND WAS UNABLE TO REPRODUCE IT A SECOND TIME

So it's probably not a very common/blocking issue...

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Jan 11, 2019

Build 5442 does not have my fix from above. Please update to the latest build. In that newer build, the "Apply" button does not change the theme at once. Instead, it just shows a message saying the user should restart HeidiSQL to apply changed settings.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Jan 13, 2019

I guess this is now solved, so I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment