New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row padding greatly reduced #468

Closed
szheng95 opened this Issue Jan 4, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@szheng95
Copy link

szheng95 commented Jan 4, 2019

Steps to reproduce this issue

Run a query result, or open the Data tab on a table.

Behavior

Effective with the 5408 update, there is noticeably reduced default padding on each row in the Data tab and in query results. The left hand side is 5407, the right hand side is 5437. Not sure if this is intentional, but it was definitely unexpected.

padding example

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Jan 5, 2019

This is not a bug. I already noticed that, and this most probably happened after my recent update to the VirtualTree component. I found this a good thing, as I get more data on the screen, while probably readability is a bit reduced, but not significantly.

That may have been unexpected, but what's your opinion about that?

@szheng95

This comment has been minimized.

Copy link

szheng95 commented Jan 11, 2019

As someone who uses the grid-edit functionality in the query results as often as I just use it as a viewer, I definitely preferred the old layout.

@ansgarbecker ansgarbecker added enhancement and removed question labels Jan 11, 2019

@ansgarbecker ansgarbecker added this to the v10 milestone Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment