New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change new line type #47

Closed
kamcio96 opened this Issue Dec 16, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@kamcio96

kamcio96 commented Dec 16, 2017

Expected behavior

Change new line type from Windows to Unix

Current behavior

Crash

Steps to reproduce

  1. Open VARCHAR value editor.
  2. Try change line endings to unix

Failure Logs

date/time          : 2017-12-16, 13:54:34, 434ms
computer name      : DESKTOP
user name          : kamcio96 <admin>
registered owner   : Użytkownik systemu Windows
operating system   : Windows 10 x64 build 15063
system language    : Polish
system up time     : 21 days 2 hours
program up time    : 1 minute 15 seconds
processors         : 4x Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz
physical memory    : 1363/7974 MB (free/total)
free disk space    : (C:) 438,93 GB
display mode       : 1920x1080, 32 bit
process id         : $5bc
allocated memory   : 71,41 MB
largest free block : 131029,99 GB
executable         : heidisql.exe
exec. date/time    : 2017-12-16 13:53
version            : 9.4.0.5193
compiled with      : Delphi XE5
madExcept version  : 4.0.12
callstack crc      : $c5601809, $061da0d0, $061da0d0
exception number   : 1
exception class    : EAccessViolation
exception message  : Access violation at address 0000000000AE1FB2 in module 'heidisql.exe'. Read of address 0000000000000078.

main thread ($3440):
00ae1fb2 heidisql.exe texteditor      130 +15 TfrmTextEditor.SelectLinebreaks
007eb6a9 heidisql.exe Vcl.Menus               TMenuItem.Click
007edfbf heidisql.exe Vcl.Menus               TMenu.DispatchCommand
007f0514 heidisql.exe Vcl.Menus               TPopupList.WndProc
007f0415 heidisql.exe Vcl.Menus               TPopupList.MainWndProc
005dbdc3 heidisql.exe System.Classes          StdWndProc
7ff8bb03 USER32.dll                           DispatchMessageW
0081469f heidisql.exe Vcl.Forms               TApplication.ProcessMessage
00814713 heidisql.exe Vcl.Forms               TApplication.HandleMessage
0080d058 heidisql.exe Vcl.Forms               TCustomForm.ShowModal
00aeb771 heidisql.exe grideditlinks  1130  +7 TInplaceEditorLink.ButtonClick
00695444 heidisql.exe Vcl.Controls            TControl.Click
006ccd66 heidisql.exe Vcl.StdCtrls            TCustomButton.Click
006cdd82 heidisql.exe Vcl.StdCtrls            TCustomButton.CNCommand
0040cb1e heidisql.exe System                  TObject.Dispatch
00694b83 heidisql.exe Vcl.Controls            TControl.WndProc
0069c24e heidisql.exe Vcl.Controls            TWinControl.WndProc
006cc7b0 heidisql.exe Vcl.StdCtrls            TButtonControl.WndProc
00694660 heidisql.exe Vcl.Controls            TControl.Perform
0069c449 heidisql.exe Vcl.Controls            DoControlMsg
0069d7c3 heidisql.exe Vcl.Controls            TWinControl.WMCommand
0040cb1e heidisql.exe System                  TObject.Dispatch
00694b83 heidisql.exe Vcl.Controls            TControl.WndProc
0069c24e heidisql.exe Vcl.Controls            TWinControl.WndProc
0069b48a heidisql.exe Vcl.Controls            TWinControl.MainWndProc
005dbdc3 heidisql.exe System.Classes          StdWndProc
7ff8bc59 ntdll.dll                            KiUserCallbackDispatcher
7ff8bb03 USER32.dll                           SendMessageW
7ff8bb03 USER32.dll                           CallWindowProcW
0069c3e9 heidisql.exe Vcl.Controls            TWinControl.DefaultHandler
00695aec heidisql.exe Vcl.Controls            TControl.WMLButtonUp
0040cb1e heidisql.exe System                  TObject.Dispatch
00694b83 heidisql.exe Vcl.Controls            TControl.WndProc
0069c24e heidisql.exe Vcl.Controls            TWinControl.WndProc
006cc7b0 heidisql.exe Vcl.StdCtrls            TButtonControl.WndProc
0069b48a heidisql.exe Vcl.Controls            TWinControl.MainWndProc
005dbdc3 heidisql.exe System.Classes          StdWndProc
7ff8bb03 USER32.dll                           DispatchMessageW
0081469f heidisql.exe Vcl.Forms               TApplication.ProcessMessage
00814713 heidisql.exe Vcl.Forms               TApplication.HandleMessage
00814bff heidisql.exe Vcl.Forms               TApplication.Run
00ca02c7 heidisql.exe heidisql         80 +24 initialization
7ff8bc2d KERNEL32.DLL                         BaseThreadInitThunk
7ff8bc56 ntdll.dll                            RtlUserThreadStart


@ansgarbecker ansgarbecker added the bug label Dec 16, 2017

@ansgarbecker

This comment has been minimized.

Collaborator

ansgarbecker commented Feb 3, 2018

Should be fixed in the next build.

Not sure how to reproduce that, as per code I was sure that could never happen. Well, obviously, I was wrong, so I made the relevant code more stable now.

ansgarbecker added a commit that referenced this issue Feb 5, 2018

Init asLineBreakStyle setting with Windows linebreaks, so we don't ru…
…n into crashes when grid value does not have any line ending. See issue #47 and https://www.heidisql.com/forum.php?t=24883

@ansgarbecker ansgarbecker added this to the v9.6 milestone Feb 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment