New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themed window title buttons not centered, and status bar clipped #483

Open
geki007 opened this Issue Jan 15, 2019 · 13 comments

Comments

Projects
None yet
3 participants
@geki007
Copy link

geki007 commented Jan 15, 2019

Steps to reproduce this issue

  1. use a not standard theme (e.g. dark win 10)
  2. maximize the heidisql window
  3. Then the windows minimize, maximize, close buttons look not correct (not in the middle), also the status bar of heidisql looks not as nice as it looks if heidi is not maximized (cutted at bottom)

Current behavior

Looks not very nice

Expected behavior

Looks like with standard theme or not maximized

Environment

  • HeidiSQL version:
    9.5.0.5454
  • Operating system:
    Win 10 x64 - 1809
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Jan 15, 2019

Please attach a screenshot for explaining what "looks not very nice" exactly means...

@ansgarbecker ansgarbecker added the themes label Jan 15, 2019

@geki007

This comment has been minimized.

Copy link
Author

geki007 commented Jan 15, 2019

Hope this helps

screenshot

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Jan 15, 2019

That looks quite normal to me. The buttons are where I would expect them, and the status bar looks ok, doesn't it?

@geki007

This comment has been minimized.

Copy link
Author

geki007 commented Jan 15, 2019

The position is normal, only the Text/Icons in it are not.
Just compare the top icons (min,max,close) with the Windows Explorer

Top:

  • X is not vertical centered (don't maximize the window and it looks a little different)

Statusbar:

  • At the bottom of the text in the statusbar should be a small padding like it's at the top of the text (also only vertical centered and little bit higher?)
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Jan 15, 2019

Ok. Then that's how the theme is defined. I did not create these myself, and I'm sure there are lots of such small glitches in them. You could of course report them to Embarcadero, but I guess the best thing is just to create a new theme without such glitches, like @CharlieEtienne did with the Material theme.

@geki007

This comment has been minimized.

Copy link
Author

geki007 commented Jan 15, 2019

Also the nice Material theme has this problem.
All themes has the problem except "Windows"!
Is there a difference (since it's not in styles.rc)?

@CharlieEtienne

This comment has been minimized.

Copy link
Contributor

CharlieEtienne commented Jan 15, 2019

I confirm I also have encountered this problem and forgot to open an issue here.

@CharlieEtienne

This comment has been minimized.

Copy link
Contributor

CharlieEtienne commented Jan 15, 2019

Also Material Theme is based on Windows 10 Dark, so I easily could have include the bug.
However it doesn't happen with FMX Style Viewer (Bitmap Style Designer Test Window), so it could come from HeidiSQL as well. I'll look on how Default Windows theme is made and update Material Theme if I can.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Jan 15, 2019

All themes has the problem except "Windows"!
Is there a difference (since it's not in styles.rc)?

"Windows" is not a theme, it's just the absence of a VCL style, and it's the default "style".

@ansgarbecker ansgarbecker changed the title Bad look when maximized and not using standard theme Themed window title buttons not centered, and status bar clipped Jan 15, 2019

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Jan 15, 2019

We can use this issue for trying to fix these buttons and status bar.

@CharlieEtienne

This comment has been minimized.

Copy link
Contributor

CharlieEtienne commented Jan 16, 2019

  1. After some Google searches, it could have something to do with "borders", since they are removed when maximizing (not sure about that).

  2. It seems that Windows remove 8px on each side of a maximized form. (See here)

  3. It doesn't happen when "snapping" the form to edges of screen. (Even when you snap to the top or bottom to make the form automatically full height as you can do it in Windows 7+)

  4. Maybe (I don't know if it's a good idea nor if it's possible) you could try to add some "padding" to a maximized form (using vcl style)...

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Jan 16, 2019

I'm pretty sure we're running into this VCL bug: https://quality.embarcadero.com/browse/RSP-14081

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Jan 16, 2019

I just updated the theme helper units from https://github.com/RRUZ/vcl-styles-utils to their latest version. Unfortunately, this does not yet fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment