Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undo is broken #541

Open
datacubed opened this issue Feb 18, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@datacubed
Copy link

commented Feb 18, 2019

Steps to reproduce this issue

Example One
Step 1
Write the following SQL:
SELECT 1;

Step 2:
Press "ctrl+z".

Example Two:
Step 1:
Write the following SQL:
SELECT 1;
SELECT 2;
SELECT 3:

Step 2:
Run

Step 3:
Press "ctrl+z" to undo.

Write a couple different lines of SQL, then press

Current behavior

Example One:
Undo removes "SELECT" and ";" while leaving the "1":
SELECT 1;

undo
1

Example Two:
Undo only behaves on the last sql statement. So I have 3 queries in the window, but only the last one is acted on - however it behaves exactly the same as Example One:
SELECT 1;
SELECT 2;
SELECT 3;

undo
SELECT 1;
SELECT 2;
3

Expected behavior

In both Examples:
Undo should remove the last character first, and continue until the Text Field is empty.

Possible solution

Environment

  • HeidiSQL version:
    10.1.0.5464

  • Database system and version:
    5.5.61

  • Operating system:
    Windows 10

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Mar 28, 2019

I suppose that the auto-uppercase feature breaks the undo history in the SynEdit's.
Can you please verifiy that, by disabling it in Preferences > SQL > "Auto uppercase reserved words and functions".

@fifonik

This comment has been minimized.

Copy link

commented Apr 2, 2019

I'm not OP, but looks like the auto uppercasing option messing up the undo.
When switched off everything looks OK.

@rentalhost

This comment has been minimized.

Copy link
Collaborator

commented Apr 2, 2019

I could confirm. The auto uppercase brokes undo.

@datacubed

This comment has been minimized.

Copy link
Author

commented Apr 8, 2019

Hey all,
I had assumed this was fixed - but turns out I had also turned off "auto uppercase".
So I would say this is the issue causing Undo to behave oddly - as seen by others here.

@ansgarbecker ansgarbecker added confirmed and removed needs-info labels Jun 4, 2019

@ansgarbecker ansgarbecker added this to the v10.3 milestone Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.