Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v10.1 freezes where v9.5 is super fast (BLOB related) #548

Closed
paulvi opened this Issue Feb 25, 2019 · 16 comments

Comments

Projects
None yet
3 participants
@paulvi
Copy link

paulvi commented Feb 25, 2019

HeidiSQL has been the fastest GUI tool.

Steps to reproduce this issue

  1. Install v10.1 on Windows 10
  2. Open databases with images in a table row of size 3 to 40 MB
  3. Then I get window is unresponsive, CPU is 25% used (1 core used 100%) for 2-3 and more minutes;
    data is refreshed 1 row in few (3-5) second, so it is like animation of getting data from db.

Current behavior

Once: No responce, no shown data after 2-3 minutes.
Once: Animation: showing data at speed 1 row in 3-5 seconds, CPU high.

Expected behavior

v9.5 installed works super fast on the same PC

Possible solution

regression, needs to know what actually was changes in 10.1 related to fetching table data that has images in BLOB

Environment

  • HeidiSQL version: 10.1
  • Database system and version:
    MySQL 5.7
  • Operating system:
    Windows 10
@carloselectro

This comment has been minimized.

Copy link

carloselectro commented Feb 27, 2019

Version 10 is indeed really slow compared to 9.5 with BLOB (WAV in my case), a table will only a few rows of data with BLOB is making it unusable.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Feb 27, 2019

This could have been introduced by 2f2e21b or a7c0883, see issue #422 and #429.

@ansgarbecker ansgarbecker added this to the v10.2 milestone Feb 27, 2019

@paulvi

This comment has been minimized.

Copy link
Author

paulvi commented Mar 1, 2019

#422 and #429 are both issues raised by me, but they are both related to Image Preview view, that is not visible by default in v10.1 and v9.5.

I second @carloselectro as the issues is definitely BLOB related.

I had to downgrade to v9.5 and warn colleagues not to upgrade.

2f2e21b has check for what button is pressed

    if SendingControl = btnPreviewCopy then begin
      imgPreview.Picture.SaveToClipBoardFormat(ClpFormat, ClpData, APalette);
      if (imgPreview.Picture.Graphic <> nil)

a7c0883 is similar for only has changes for Image Preview

While what I saw, is was very slow showing row of data in table view.

If there is logic to call Image Preview refresh after drawing each line in the table, that is just wrong.
I think, table should fully display query data, then other views should be refreshed depending on current line within the table.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Mar 2, 2019

One reason for that slowness is definitely 651b485, which I am going to revert partially now. That will make the grid load the first 256 bytes from BLOBs, and load the rest when a row gets focus. Currently, the grid loads the entire BLOB contents of all visible rows into the grid, with a dumb SELECT * FROM mytable .

ansgarbecker added a commit that referenced this issue Mar 2, 2019

Issue #548: Revert a line from 651b485 which lead to loading entire B…
…LOB contents into the grid, instead of the first 256 bytes only.
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Mar 2, 2019

@paulvi please report back if the upcoming build fixes this slowness for you also. For me it works, apart from the faulty detection of not yet loaded images, but that is a different issue.

@paulvi

This comment has been minimized.

Copy link
Author

paulvi commented Mar 4, 2019

Is it possible to install/try beta without affecting currently used version?

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Mar 4, 2019

You can download the new build from the downloads page manually, and put it into the same folder as heidisql.exe, where the new build has the filename heidisql.xyz.exe . They should both run and not affect each other.

@paulvi

This comment has been minimized.

Copy link
Author

paulvi commented Mar 5, 2019

OK, so it is trying out other build exe'cutable side-by-side with main one.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Mar 5, 2019

Could you already test if my change effectively enhanced speed?

@paulvi

This comment has been minimized.

Copy link
Author

paulvi commented Mar 6, 2019

OK, just tell when there is build that has this issue fixed.

For me it means that newer version should not be worse then previous.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Mar 6, 2019

@paulvi

This comment has been minimized.

Copy link
Author

paulvi commented Mar 6, 2019

OK, but there were no commits for this issue....

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Mar 6, 2019

Yes, there is - the third one from top currently, build 10.1.0.5485. Watch out for the issue number 548 in the comment. I recommend downloading the very latest one.

@paulvi

This comment has been minimized.

Copy link
Author

paulvi commented Mar 6, 2019

Well, latest build worked quick, but there are other regressions over v9.5

  • when showing BLOB content , it is not showing all bytes but squares

image

  • and HeidiSQL is freezing when trying Image Preview view

image

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Mar 6, 2019

Weren't these mentioned in other tickets? Are they directly related to this issue about speed?

@paulvi

This comment has been minimized.

Copy link
Author

paulvi commented Mar 6, 2019

well, these 2 should be other non-related tickets for 10.x

@paulvi paulvi closed this Mar 6, 2019

@paulvi paulvi changed the title v10.1 freezes where v9.5 is super fast v10.1 freezes where v9.5 is super fast (BLOB related) Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.