Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort encodings in Import CSV File modal? #579

Closed
leeoniya opened this Issue Mar 18, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@leeoniya
Copy link

leeoniya commented Mar 18, 2019

by either most common or alphabetical?

my go-to is UTF-8 Unicode (utf8), which is probably a sane default to have, too.

sort_encoding

thanks!

@ansgarbecker ansgarbecker added this to the v10.2 milestone Mar 18, 2019

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Mar 18, 2019

I suppose the default should still be what the database is set to. Probably the second item should then be utf-8. For the rest I suppose it's a good idea to move the short names to the left, then sort them alphabetically:

  • latin1: Database default
  • utf8mb4: UTF-8 Unicode
  • armscii8: ARMSCII-8 Armenian
  • ascii: US ASCII
  • ...
@leeoniya

This comment has been minimized.

Copy link
Author

leeoniya commented Mar 18, 2019

maybe it makes sense to just keep them strictly alphabetical, pre-select the database default, and add something to the settings to override the pre-selected default. having them be in quasi-alphabetical order is still kind of hard to look at, IMO.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

ansgarbecker commented Mar 18, 2019

Yes, sounds reasonable. Just pushed that, a quite large commit for just having a different sorting here, but I had to reinvent some wheels in the code:

grafik

@leeoniya

This comment has been minimized.

Copy link
Author

leeoniya commented Mar 19, 2019

ah, much better now. thanks a ton, as always! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.