Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Delete selected row" button is disabled when navigating the rows of a table using the keyboard #624

Closed
Ivan-Perez opened this issue Apr 24, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@Ivan-Perez
Copy link
Contributor

commented Apr 24, 2019

Steps to reproduce this issue

  1. Go to the data tab of any table.
  2. Click on a row. At this moment, the delete button for that row and its keyboard shortcut (Ctrl+Del) are enabled.
  3. Move to another row using the keyboard (i.e. press down arrow).
  4. The delete button is no longer enabled, nor is its shortcut. Clicking on that row or on any other reenables it.

A gif is worth a thousand words. Look at the delete button, it isn't always enabled:

bug

Current behavior

Already described.

Expected behavior

The button should always be enabled.

Possible solution

.

Environment

I don't remember if this behaviour didn't exist in a previous version, but as far as I can remember, this issue is happening to me since long ago (I would bet one year at least, if not since ever), but haven't decided to open this bug report until now :)

  • HeidiSQL version: 10.1.0.5545
  • Database system and version: MariaDB 5.5.60
  • Operating system: Windows 10

@ansgarbecker ansgarbecker added this to the v10.2 milestone Apr 30, 2019

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Apr 30, 2019

Also, selecting rows by mouse via dragging a rectangle disables the delete button.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Apr 30, 2019

I had to trigger control/button validation also in the grid's OnChange event, which is fired quite often, so cross fingers this does not harm performance.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Apr 30, 2019

By the way, I am curious: how did you create that screen-animation from above?

@Ivan-Perez

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

I had to trigger control/button validation also in the grid's OnChange event, which is fired quite often, so cross fingers this does not harm performance.

Thanks, it works perfectly! I don't see any performance loss at the moment.

By the way, I am curious: how did you create that screen-animation from above?

I used the first tool I found on Google. In this case, it was ScreenToGif.

By the way, I think Gyazo is the most popular tool to make short GIFs/MP4 taken from the screen, but I didn't remember its name when I opened this issue so I tried another program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.