Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong word in Danish translation #627

Closed
petersone opened this issue Apr 26, 2019 · 16 comments

Comments

Projects
None yet
3 participants
@petersone
Copy link

commented Apr 26, 2019

Steps to reproduce this issue

  1. Select lines in command window
  2. Right click selection

Current behavior

"Kør" is a wrong translation of Cut.
Right-click-error-DK

Expected behavior

Use the Danish word "Klip"

Possible solution

Fix it!

Environment

DK translation of user interface.

  • HeidiSQL version:
    10.1.0.5546

  • Operating system:
    Windows 10

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Apr 27, 2019

Translation are managed on Transifex. Danish has quite a large pool of yet untranslated strings. Probably you could help out here?
If yes: you will need to log into https://www.transifex.com/david.proweb/heidisql/dashboard/ , then navigate to the Danish translation.
If no, I can myself fix this one word as you proposed, but my Danish is a bit rusty... ;) so I won't be able to get it fully translated.

@WesleyM77

This comment has been minimized.

Copy link

commented May 6, 2019

Might I suggest putting that Transifex link in the readme and on Heidi's site (not in a forum post) so people can find the way to contribute easier?

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented May 7, 2019

Yes of course. It's already in the credits section of the help page, but I guess you mean in the readme.md ?

@WesleyM77

This comment has been minimized.

Copy link

commented May 7, 2019

Yeah, that would probably be a good place for it since most people looking to contribute in some way are going to read that. Also didn't realize it was in the credits section.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented May 7, 2019

I just added a note to the readme file.

So I guess I can close this issue. The danish word in question may still be wrong translated, but probably you are going to fix that on Transifex now?

@petersone

This comment has been minimized.

Copy link
Author

commented May 8, 2019

I tried to translate multiple strings... but they end up in the group of "not approved" words - where many other Danish translations also reside (right now 836 translations).
It's fair not to be able to approve your own translations... but I could then approve translations done by others - but how do I do that - I cannot find the "approve button"... ;-)

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented May 8, 2019

I was not aware of the fact that reviewing cannot be done by translators. I wonder how the current strings were reviewed, as I did not do so.

However, I changed your role from translator to reviewer, and I hope you still can translate now:
grafik

Could you please test if you still can translate new strings, and if you can mass-review unreviewed translations?

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented May 8, 2019

Did we both think your done translations were not overtaken into the latest builds? They are there, and I see Klip as a translation for Cut. Unfortunately there is also Cu&t, which translates to &Kør. Maybe that was just the misunderstanding? I should again change your role to translator..

@petersone

This comment has been minimized.

Copy link
Author

commented May 9, 2019

Looking at Transifex now... I'm not a reviewer.
Transifex

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

Yes, I already moved your username back into the translator role. Could you please check whether your translated strings are present in the last build of HeidiSQL? Be aware that we have "Cut" and "Cu&t".

@petersone

This comment has been minimized.

Copy link
Author

commented May 9, 2019

No, my translations (and others) have not been approved:
Translation

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

Yes, you said so, and you are right - some are not approved reviewed. But as said, I'm sure they don't need to be approved reviewed. And be aware we have "Cut" and "Cu&t", of which the latter one is translated to "Kør". Only "Cut" is translated to "Klip". You need to fix the wrong translation for "Cu&t".

@petersone

This comment has been minimized.

Copy link
Author

commented May 9, 2019

Where can I read about the use of & as part of keys?

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

The & is a Delphi thing. It tells the compiler to use the following character as a hotkey. Nothing special for the translation.

@petersone

This comment has been minimized.

Copy link
Author

commented May 9, 2019

Cu&t has been translated.

Q: How should "we" handle the & operator, when the DK word doesn't have the same characters as in EN?
Example: Cut -> Klip
So Cu&t marks "t" as hotkey... what to do in the DK translation?

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

Ah, good question.

The simplest thing is just to leave that & away from it in the translated word. You could (but I don't recommend) adding a & before a character you like, but you will never know if that collides with other hotkeys. So, just leave it away I'd say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.