Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read-only mode for grid cell editors #631

Closed
magnetik opened this issue Apr 30, 2019 · 7 comments
Closed

Read-only mode for grid cell editors #631

magnetik opened this issue Apr 30, 2019 · 7 comments
Labels
Milestone

Comments

@magnetik
Copy link

@magnetik magnetik commented Apr 30, 2019

Steps to reproduce this issue

  1. Connect to a MySQL 8 server
  2. In query tab, do SHOW ENGINE INNODB STATUS
  3. Double click on the first row, in Status column that containts a lot of text

Current behavior

Grid editing error

Could not determine name of table.

Expected behavior

Window to show full content of this field.

Environment

  • HeidiSQL version: 10.1.0.5549
  • Database system and version: MySQL 8
  • Operating system: Windows 10
@Ivan-Perez

This comment has been minimized.

Copy link
Contributor

@Ivan-Perez Ivan-Perez commented Apr 30, 2019

What I do in those cases, as a workaround, is to copy the cell and paste the contents into the editor of your choice.

@magnetik

This comment has been minimized.

Copy link
Author

@magnetik magnetik commented Apr 30, 2019

That's what I'm doing, but I find the little editor in heidisql quite convenient so it would be cool if it worked.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Apr 30, 2019

This was a topic several times already. And I suppose it's time to create some solution here.

see

Actually, HeidiSQL blocks all editing in any situation where my database layer cannot find an underlying table plus column name. I understand you did not intend to change the contents, but for HeidiSQL, the popup text editor is strictly for editing, not just for displaying purposes.

So, my idea is to support a read-only mode in all the different grid cell editors if the database says there is no table column involved here.

@ansgarbecker ansgarbecker changed the title Cannot see full content of row in Show engine status Read-only mode for grid cell editors Apr 30, 2019
@magnetik

This comment has been minimized.

Copy link
Author

@magnetik magnetik commented Apr 30, 2019

Oh yes, I was not expecting for this to be such a large change.

This seems like a great solution indeed !

Thanks for your time and your fast response :) 👍

@ansgarbecker ansgarbecker added this to the v10.4 milestone Oct 13, 2019
@ansgarbecker ansgarbecker pinned this issue Feb 6, 2020
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Feb 6, 2020

Next build finally has a read-only mode in query grids, allowing the text editor and other editors to pop up:

grafik

@ansgarbecker ansgarbecker unpinned this issue Feb 6, 2020
@Ivan-Perez

This comment has been minimized.

Copy link
Contributor

@Ivan-Perez Ivan-Perez commented Feb 6, 2020

It's working nicely! Thank you Ansgar!

@magnetik

This comment has been minimized.

Copy link
Author

@magnetik magnetik commented Feb 6, 2020

awesome ! Thanks a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.