Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search and Replace generates HTML #634

Open
cookieguru opened this issue May 1, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@cookieguru
Copy link

commented May 1, 2019

Steps to reproduce this issue

  1. Search and replace for a URL
  2. Replace all occurrences

Search and replace screenshot

Current behavior

Dialog shows HTML

Expected behavior

Text in dialog does not contain HTML or HTML is rendered.

In the above example I would expect to see

Text "http://www.example.com/" 1 times replaced.

And also

Text "%s" %s times replaced. would make more sense to be reworded as Text "%s" replaced %s times.

  • HeidiSQL version: 10.1.0.5550

rentalhost added a commit that referenced this issue May 13, 2019

@rentalhost

This comment has been minimized.

Copy link
Collaborator

commented May 13, 2019

Reproduced at r5560.

Replacement suggestion PR as #648.

About the issue itself, it seems to be related to this line:

Dialog.Text := rx.Replace(Msg, '<a href="$0">$0</a>', True);

Edit: I could not found here this replacement is used, so maybe it could be dropped from code (before-post-edit: ok, I found a single usage here, and maybe it could be just updated to use a[href] instead of apply it to all dialogs, and too, I don't know if it will really create an a[href] directly to dialog as expected).

ansgarbecker added a commit that referenced this issue May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.