Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows10 SlateGray theme problems in "Save as snippet..." and "Save as..." #649

Closed
anselal opened this issue May 13, 2019 · 11 comments
Milestone

Comments

@anselal
Copy link

@anselal anselal commented May 13, 2019

Steps to reproduce this issue

  1. Set the Style Theme to Windows10 SlateGray
  2. Right click on a query window and select "Save as snippet..." or "Save as..."

Current behavior

The left tree and the items on the dropdown list while typing a new appear in white.

2019-05-13_12h13_31

Expected behavior

The items on the window should all adopt the themes properties

Possible solution

Don't know

Environment

  • HeidiSQL version:
    10.1.0.5555
  • Operating system:
    Windows 10 64bit 1809
@WesleyM77

This comment has been minimized.

Copy link

@WesleyM77 WesleyM77 commented Jul 15, 2019

Also having this issue with Material. Thought this was due to my session background setting, but I changed it from 'Default' to 'None' and it didn't seem to change anything. On Heidi 10.2.0.5629.
heidisql_2019-07-15_11-26-01

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Jul 21, 2019

I cannot reproduce that white panel any more, for some reason:

grafik

I am going to push updates from the vcl-styles-utils project.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Jul 21, 2019

cfe412e has various updates for themes. Please test by updating to the latest build of HeidiSQL in a few minutes.

@anselal

This comment has been minimized.

Copy link
Author

@anselal anselal commented Jul 22, 2019

Yeap,

that fixed the background.

Thanks a lot !!!

@anselal anselal closed this Jul 22, 2019
@anselal anselal reopened this Jul 22, 2019
@anselal

This comment has been minimized.

Copy link
Author

@anselal anselal commented Jul 22, 2019

Although the white background remains the in dropdown when you type a filename.
I guess this is not related to any bug of the software so we can close this issue ??

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Jul 22, 2019

I'm not sure. According to RRUZ/vcl-styles-utils#249 the edit and dropdown boxes should be painted in the right color, not in white.

@ansgarbecker ansgarbecker added this to the v10.3 milestone Jul 22, 2019
@anselal

This comment has been minimized.

Copy link
Author

@anselal anselal commented Nov 4, 2019

Updated to the latest 10.2.0.5736.

The issue is not completely resolved. When I start typing the background has the desired color (not white)

2019-11-04_08h34_14

but when I don't type anything and expand the dropdown then the background is still white.

2019-11-04_08h34_39

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Nov 4, 2019

I'll have a look if the changed file from salvadordf/vcl-styles-utils@16730fd is really used in HeidiSQL.

@ansgarbecker ansgarbecker reopened this Nov 4, 2019
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Nov 10, 2019

The dialog for loading an SQL file is a TOpenTextFileDialog, while e.g. the session manager's startup script selector is a TOpenDialog. The latter one paints correctly, so there is some difference in their code which is apparently not caught up by the above mentioned fix.

I just asked why these differences exist on delphipraxis.net.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Nov 11, 2019

Sorry for the confusion - I mixed up the save dialog with the open dialog. The save dialog has this wrong background color in the dropdown. The open text file dialogs have even more issues - they look like in old XP.

I could go and exchange the old-style open dialog with a newer dialog and extend it like described in this blog post, but to be honest, that is too much effort for now.

For these background colors on the save dialog, I suppose we just accept that. I have no clue how to fix that.

@anselal

This comment has been minimized.

Copy link
Author

@anselal anselal commented Nov 12, 2019

If it is too much trouble that is ok. I just pointed out the issue.

It would be nice to be fixed but the main reason I use HeidiSQL is not the dark themes but it's features !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.