Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment field re-escape escaped characters #690

Closed
davekc opened this issue Jun 25, 2019 · 6 comments

Comments

Projects
None yet
2 participants
@davekc
Copy link

commented Jun 25, 2019

Steps to reproduce this issue

  1. Save a column comment as "\-\."
  2. The comment saves as "\\-\\."
  3. Then same again (even without modifying the comment itself)
  4. The comment saves as "\\\\-\\\\."

Current behavior

Column comment re-escape escaped characters

Expected behavior

Comment field should save as entered

Environment

  • HeidiSQL version:
    10.2.0.5607
  • Database system and version:
    10.3.16-MariaDB
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Jun 26, 2019

Heidi takes the table comment from the most recent result of SHOW TABLE STATUS, to not include unwanted create options, like described in #196.
However, backslashes are not double-escaped here, on MariaDB 10.3.12 . But maybe you can post the result of these both queries:

SHOW TABLE STATUS LIKE 'yourtable';
SHOW CREATE TABLE yourtable;
@davekc

This comment has been minimized.

Copy link
Author

commented Jun 26, 2019

Here's the requested informations:
heidi.txt

Also, to simply let you know that it works (without escaping issue) under an old Navicat MySQL version I have (v9.1.12) even if I am using MariaDB...

Thanks a lot!

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Jun 26, 2019

Are we now talking about a column comment?
In the opening comment you said it's a table comment.

@davekc

This comment has been minimized.

Copy link
Author

commented Jun 26, 2019

So sorry, my mistake... always been a column comment! 😳

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Jun 26, 2019

Ok no problem. That explains my confusion while testing that. However, column comments should work in the latest build - I fixed the incomplete un-escape logic.

@ansgarbecker ansgarbecker added this to the v10.3 milestone Jun 26, 2019

@davekc

This comment has been minimized.

Copy link
Author

commented Jun 26, 2019

Yes it is, working like a charm now. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.