Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Same text background' color should highlight same data in same row, not only same column as selected cell #707

Closed
yphastos opened this issue Jul 8, 2019 · 7 comments
Labels
Milestone

Comments

@yphastos
Copy link

@yphastos yphastos commented Jul 8, 2019

Steps to reproduce this issue

  1. Step 1; make sure the "Same text background" option (under "grid formatting") is set to a noticeable color.
  2. Step 2; have some results with several rows and columns and same data on other rows, AND also other columns
  3. Step N; select a single cell which has same data in same column of other rows, but also same data on other columns of selected row
  4. Then I get...

Current behavior

The cells from the other rows in the same column with the same data as currently selected get highlighted as expected, but the cells in other columns, but in the SAME row with the SAME data do not get highlighted as expected.

image

Here the cells with '2' in other rows and same column get highlighted, but the cells with '2' in the SAME row don't get highlighted, they remaing with the 'selected row' gray background color.

Expected behavior

All the cells in the same ROW and COLUMN with the same data as the current selected cell should be highlighted. i.e. among the 'cross' formed by the current row and column

Possible solution

Just guessing, maybe the option correctly detects same data, but when it attempts to paint them, the 'selected row' background gets a higher priority and overrides the "same text background" color.

i.e. the 'same text background' color should have higher priority over the currently selected row, for cells with matching data of course

Environment

  • HeidiSQL version: 10.2.0.5599

  • Operating system: MacOS 10.13.6, running heidi under Wine

@yphastos

This comment has been minimized.

Copy link
Author

@yphastos yphastos commented Jul 8, 2019

Additional comments.

It would be VERY useful on cases in which we need to compare data in several columns, where navigating the results with the keyboard would easily highlight matching data in other columns, instead of having to make custom queries like if(a = b,'match','no match') as a_matches_b

Highlighting the same data in the whole result table (not only selected row/column) would be useful sometimes, but i guess it would be more 'expensive' to process and would be visually messy, so it is not that important. or maybe as a toggleable option?

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Jul 8, 2019

I agree it's useful and worth it to take the focused row into account. But doing that on the whole grid would break it somehow. So I'll go and apply it on the row first.

@ansgarbecker ansgarbecker added this to the v10.4 milestone Jul 8, 2019
@yphastos

This comment has been minimized.

Copy link
Author

@yphastos yphastos commented Jul 8, 2019

Thanks!

Although it would be nice to have it sooner than 10.4. but I'm happy you will eventually implement it.

@ansgarbecker ansgarbecker modified the milestones: v10.4, v10.3 Jul 8, 2019
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Jul 8, 2019

Well, then let's try it for 10.3. I just wanted to limit the pressure on myself for the next release. These remaining high-dpi issues are such a pain in the ass.

@yphastos

This comment has been minimized.

Copy link
Author

@yphastos yphastos commented Jul 8, 2019

Wow thanks! I really appreciate it.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Oct 30, 2019

This is how that looks like in the next build:

grafik

We should test that for some time, maybe there are reasons to highlight same cells in the whole grid. But for now I don't think so, especially when looking at this particular table.

@yphastos

This comment has been minimized.

Copy link
Author

@yphastos yphastos commented Oct 30, 2019

Perfect! It works flawlessly.

And I agree that highlighting the whole grid would be too much, and only useful under a few cases.

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.