Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent/counterintuitive count of rows and columns in results between tab title and selected cell in toolbar #712

Closed
yphastos opened this issue Jul 11, 2019 · 10 comments

Comments

@yphastos
Copy link

commented Jul 11, 2019

Steps to reproduce this issue

  1. Have a query which results in a different amount of rows vs amount of columns
  2. The result tab shows the number of the query, and the count of items, in the form:

Result #<n> (<columns> x<rows>)

imagen

  1. In the bottom bar (don't know how it is called), when you click on any cell, it shows the 'coordinates', but the format is inverted, it shows it as:

<row> : <column>

imagen

Current behavior

The row/column count is inconsistent in order, because one show column then row, and the other the opposite. Plus, it is not intuitive to deduce which number is row or column

Expected behavior

Both cases should show at least be in the same order. Or better, to indicate what each number means.

Possible solution

Change the order of either one to match the other. This has the disadvantage of still not being intuitive to recognize each.

Additionally, just add a label indicating which case each number means, e.g.

In tab:
Result # 1 (3 columns x 79 rows) or with just a letter, e.g.: Result #<n> (3c x 79r)

and in status bar:
row 79 : col 3, or with a letter: r79 : c3

This way with only a glimpse it would be clear, both the global count and the current selection coordinates.

Environment

  • HeidiSQL version: 10.2.0.5599
@ansgarbecker ansgarbecker added this to the v10.3 milestone Jul 12, 2019
ansgarbecker added a commit that referenced this issue Sep 17, 2019
…status bar panel, and unify order of x + y
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Sep 17, 2019

What about using some Unicode arrow characters for that purpose:

grafik

Whether that does not show a broken character will depend on the selected font, and probably Wine has problems with it, not sure. But at least Tahoma and Segoe on Windows 10 seem to support these arrows.

Check out the next build to see it yourself.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Sep 17, 2019

By the way, these are

  • &#8596; / &harr; and
  • &#8597; / &updownarrow;

Found them on the greatest page for Unicode characters on the web from NDP Software and Andrew J. Peterson: http://www.amp-what.com/unicode/search/arrow

@yphastos

This comment has been minimized.

Copy link
Author

commented Sep 17, 2019

Perfect!
They DO work in wine, in the results tab:

image

But wasn't it supposed to also show them on the status bar? Because in there it still shows <column> : <row> but without the arrow characters:

image

Could it be maybe because the status bar uses a different font? (I have no idea)

Thanks!

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Sep 18, 2019

Hm, it seems the status bar shows a space instead of the arrow. Comparing your new screenshot with your old one reveals that - look at the increased space between "3" and ":"
grafik
grafik

Could be a Wine issue then, although the font is the same.

Could you please go to Tools > Preferences > General, and select a different GUI font, to see if that makes a difference?

I can also try and use hex codes instead of real Unicode characters in the code, to prevent read errors.

@leeoniya

This comment has been minimized.

Copy link

commented Sep 18, 2019

i too experience this confusion (most often with small result sets where the numbers are close), but i'm not a huge fan of the proposed solution. the arrows are tiny and the vertical one resembles a "1" which is even worse. in addition, i very rarely care about the column count in a grid or query result and always care about the row count. IMO, rows should always come first and if you feel that columns are important enough to always show, then maybe 75,509 rows (11 cols) or 75,509 x 11 cols. additionally, if there was an option to disable column counts, i would have them permanently disabled.

my $0.02

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Sep 18, 2019

Well ok, it was worth an attempt, because there is not much space for more text. But I see they make new problems.

So, Notepad++ displays this in the status bar, taking quite much horizontal space:
grafik
PHPStorm does it very compact, which may also be not intuitive:
grafik
MS Notepad does it similar to Notepad++, but with less spaces:
grafik

Note that we're talking about two different places. The above screens are all from the status bar. Heidi also has the result tabs, and I start to think they need different approaches.

@yphastos

This comment has been minimized.

Copy link
Author

commented Sep 18, 2019

Update, this time I am trying from a windows machine, and here it does show them correctly:

image

So I guess it is indeed a Wine / fonts related problem.
Regarding changing the GUI font, I will try it tomorrow, when I get back to my Mac.

However, as leeoniya mentions, it may be better to just use standard characters instead of unicode. This way you'd have the most compatibility.

As I initially suggested, a better choice would be to just use 'r' and 'c' for rows and columns:
r79 : c3 or 79r : 3c. I also prefer the row count first. And this way you can save the spaces between the counters and the letters.

IMO it is fairly understandable. Plus you could add a tooltip to clarify, e.g. show 79 rows : 3 columns when the user hovers the text.


Somehow unrelated. When I tried to install with the HeidiSQL_10.2.0.5693_Setup.exe file (at Windows), my Avast Antivirus detected it as a possible threat. I managed to install it by adding the installer to a white list, but then, running the program (not the installer), it again reported it as a possible threat. I overcame that by temporarily disabling the Avast shields.

This didn't happen before, but the Avast program/definitions have recently updated so I am fairly sure it is a false positive.

@leeoniya

This comment has been minimized.

Copy link

commented Sep 18, 2019

r79 : c3 seems too cursor/positional to me. like row 79 col 3. 79r : 3c is better but still has the same problem. : usually represents position the goto command in text editors is frequently asked for in [line] : [col] form.

maybe 107r x 13c in results tabs and r107 : c13 in status bar.

either way, i think showing te rows before columns is uncontroversial.

@yphastos

This comment has been minimized.

Copy link
Author

commented Sep 18, 2019

maybe 107r x 13c in results tabs and r107 : c13 in status bar.

Sounds good to me. In the tab it shows as the fixed count of resulted rows and columns, and in the status bar it means the CURRENT selected cell (or the total as well if no cell is selected).

Funny, until now, I haven't noticed that if instead of the results you click/move the prompt in the query editor, the status bar also shows the current cursor position (coordinates).


And about Avast antivirus, I just got a notification that the installer has been scanned by them and found to be harmless. I guess their database didn't have such installer 'validated' yet

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Sep 29, 2019

maybe 107r x 13c in results tabs and r107 : c13 in status bar.

Sounds good to me.

That's it now. See the next build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.