Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut support is not perfect, Bug? Or it is not provided. #719

Closed
id0612 opened this issue Jul 18, 2019 · 2 comments

Comments

@id0612
Copy link

commented Jul 18, 2019

Steps to reproduce this issue

  1. Step 1;
    Close unsaved query labels.
  2. Step 2;
    When prompted to save, press Y, N, or C to indicate Yes, No, or Cancel。

Current behavior

When the buttons are displayed in English, those buttons trigger the corresponding function. For example, use the software language: en or zh_CN (the current version of the deleted language package, because it is incomplete, so these buttons are also shown as English), but this is not valid when the language we are using makes the text displayed on these buttons not English. For example: zh, ja

Expected behavior

It is recommended that this feature be well supported and not affected by language. It will be more convenient to use.

Possible solution

With the support of the operating system, like the operating system menu, dialog button support common single-letter shortcut keys.

ansgarbecker added a commit that referenced this issue Sep 26, 2019
…ngs from user32.dll over our translation from Transifex
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Sep 26, 2019

Next build uses strings from user32.dll in your Windows folder. These are translated even when HeidiSQL cannot provide a translation. Also, some of them have hotkeys. This is a prompt on a German Windows system with HeidiSQL being set to English:

grafik

I had to guess a little what you mean, but I'm nearly sure you were talking about exactly these localized buttons and shortcuts. I found this is a good idea, as this even works without a manual translation.

@ansgarbecker ansgarbecker added this to the v10.3 milestone Sep 26, 2019
@id0612

This comment has been minimized.

Copy link
Author

commented Sep 27, 2019

Great, you made it happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.