Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with EInvalidOp when parsing big number as time #735

Closed
iggyvolz opened this issue Aug 12, 2019 · 2 comments

Comments

@iggyvolz
Copy link

commented Aug 12, 2019

Steps to reproduce this issue

  1. Create table test with a BIGINT column: CREATE TABLE test (time BIGINT(20));
  2. Insert a large number into the table: INSERT INTO test VALUES( 9223372036854775807 );
  3. Open the Data tab for the table, right-click the column and check "This is a UNIX timestamp column" (or, if it's already interpreted as a UNIX timestamp, open the data tab)

Current behavior

HeidiSQL crashes with the following crash (EInvalidOp: Invalid floating point operation).

bugreport.txt

Expected behavior

HeidiSQL displays the cell as normal (with an absurdly large year)

Possible solution

This appears to be some sort of overflow.

Environment

  • HeidiSQL version: 10.2.0.5599 (64 bit)

  • Database system and version: MariaDB 10.4.7

  • Operating system: HeidiSQl running on Microsoft Windows [Version 10.0.17763.437]; database running on WSL1, Ubuntu 18.04 distribution

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Aug 13, 2019

Next build catches more than the previously only EConvertError exception, so this may heal this issue. Only there are some limitations on the internal date/time types, which will lead such big numbers to be converted to 1970-01-01.
Please check and report back.

@ansgarbecker ansgarbecker added bug needs-info wine and removed wine labels Aug 13, 2019

@ansgarbecker ansgarbecker added this to the v10.3 milestone Aug 13, 2019

@iggyvolz

This comment has been minimized.

Copy link
Author

commented Aug 13, 2019

Confirmed, the bug is no longer appearing in 10.2.5675. Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.