Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXPLAIN links should be disabled whith no SQL in selected process #738

Closed
id0612 opened this issue Aug 15, 2019 · 0 comments

Comments

@id0612
Copy link

commented Aug 15, 2019

Steps to reproduce this issue

  1. Step 1;

Connect the database to the process list. By default, the Process SQL related button is not available.
image

  1. Step 2;
    Select any process and these buttons become available, including when there are no SQL statements.
    image

  2. Step 3;
    Clicking the EXPLAIN button will trigger an error when the text field below the button has no SQL statement.
    image
    image

Current behavior

If only the process is selected, the button will become available, causing an error if the EXPLAIN is clicked in this case.

Expected behavior

When there is no SQL to analyze, the button is unavailable or more friendly. Avoid errors.

Possible solution

The available state of the button changes depending on whether a valid SQL is selected, or when the button is clicked, the judgment is made first, and the prompt is not analyzed. I prefer the previous one.

Environment

image

@ansgarbecker ansgarbecker changed the title SQL analysis button, interactive experience suggestion optimization EXPLAIN links should be disabled whith no SQL in selected process Aug 15, 2019

@ansgarbecker ansgarbecker added this to the v10.3 milestone Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.