Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session background color not updated on save #745

Closed
Joey79100 opened this issue Sep 3, 2019 · 2 comments
Closed

Session background color not updated on save #745

Joey79100 opened this issue Sep 3, 2019 · 2 comments
Labels
Milestone

Comments

@Joey79100
Copy link

@Joey79100 Joey79100 commented Sep 3, 2019

Steps to reproduce this issue

  1. Open the session manager
  2. Select a session
  3. Change its background color
  4. Save the session settings

Current behavior

The currently opened session background color remains the same. It only changes if I restart HeidiSQL, or reopen the session.

Expected behavior

The currently opened session background color gets updated as soon as I save the new session settings.

Possible solution

I'm wondering if this was intentional or not. If it was, you could add a checkbox next to the background color selector: "Also update color for already open sessions".

Environment

  • HeidiSQL version: 10.2.0.5683 (2019-08-26 12:06:41)
  • Operating system: Windows 10
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Sep 3, 2019

There is no setting which applies to an open session. E.g. the password and whatever only applies for newly opened sessions. But I guess making an exception here can be ok for harmless things like the color.

@ansgarbecker ansgarbecker added this to the v10.4 milestone Sep 3, 2019
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Dec 11, 2019

I just pushed a change which applies the color in the back when you press the save button.

Are there more settings which should be applied to a living connection?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.