Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreign key value finder in grid #762

Open
Paulo30500 opened this issue Oct 4, 2019 · 7 comments

Comments

@Paulo30500
Copy link

commented Oct 4, 2019

Steps to reproduce this issue

  1. Step 1
    Unzip "essai.zip"
    essai.zip
  2. Step 2
    Start "essai.sql" with HeidiSQL
    Click "lecteurs" on left
    Click "Data" on right
  3. Step 3
    Double click anywhere in column "departement" or "pays"
    The name of the "departement" or "pays" appears with its id
  4. Then I get...
    Double click anywhere in column "ville"
    The list of the 36466 "ville" (cities) doesn't appear...
    Then it's impossible to select a "ville" !!!

Current behavior

IMG_20191004_121455

The list of all the "departement" or "pays" appears with id
Then I can easily select the "departement" or the "pays" that I want.

Expected behavior

IMG_20191004_121441

The list of all the 36466 cities ("villes") possible where I can select one...

Possible solution

See the list of all the "ville" (cities) where I can select the "ville" that I want...

Environment

  • **Database system and version:**HeidiSQL version: 10.2.0.5706
  • Operating system: Windows 10
ansgarbecker added a commit that referenced this issue Oct 5, 2019
…oo many rows in the connected table, and raise limit from 1000 to 10000.
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Oct 5, 2019

Your "villes" table contains more than 1000 rows, and the foreign key drop-down has a hardcoded limit of 1000 items.

I just pushed two changes here:

  • an informational message will show the limit in the SQL log panel, if the connected table has too many rows
  • raises the limit from 1000 to 10000 items

That limit prevents users from memory problems, when the target table has millions of rows.

To check the above change, just update to the next HeidiSQL build and try again.

Also, please report back what you think of it now.

@Paulo30500

This comment has been minimized.

Copy link
Author

commented Oct 5, 2019

No it doesn't work ! Perhaps with 40000 items...
Note that it's working very well with DBeaver Community (for example) without memory problem...

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Oct 5, 2019

If DBeaver works without any problem, then what is the maximum of items it shows in that drop-down? A screenshot would also be nice.

@Paulo30500

This comment has been minimized.

Copy link
Author

commented Oct 5, 2019

With Dbeaver, I can type an ID or a part of the name of a city ("villes") to select all the cities beginning like... And select the city I want...
In this way, I think DBeaver is listing 1000 rows...
IMG_20191005_171450

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Oct 6, 2019

Ah I see, DBeaver does it with a separate table control, not a simple drop-down.

Maybe HeidiSQL should get a similar approach then. Probably I can create a new foreign key value selector for this purpose, and replace the old drop-down.

@ansgarbecker ansgarbecker removed the needs-info label Oct 6, 2019
@ansgarbecker ansgarbecker added this to the v10.4 milestone Oct 6, 2019
@ansgarbecker ansgarbecker changed the title The foreign key doesn't work Foreign key value finder in grid Oct 6, 2019
@Paulo30500

This comment has been minimized.

Copy link
Author

commented Oct 14, 2019

Good idea ! I hope for a solution very soon...

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

commented Oct 14, 2019

Well the idea is not very exact yet, so feel free to post ideas here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.